Report Active Job jobs through sentry-rails by default

未关闭
#3,222 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
ruby

调研方向

Read the related changes in getsentry/sentry-ruby#3130, #3134, #3145, and #3173, then locate each adapter's Railtie and its handling of Sentry::Rails.active_job_owns_adapter?. Update Sidekiq, Resque, and Delayed Job so Active Job reporting defaults to sentry-rails ownership while preserving the documented opt-out behavior. Verify the adapter and Rails integration tests cover error and span reporting; the issue identifies no test files.

由索引模型根据 Issue 内容生成。

描述

active_job breaking change Next Major sentry-delayed_job sentry-rails sentry-resque sentry-sidekiq

Since 7.3.0, Sidekiq, Resque, and Delayed Job can hand their Active Job jobs to sentry-rails instead of reporting them through their own integration. This is opt-in today. In the next major, sentry-rails should own Active Job reporting for these adapters by default.

  • Each adapter's Railtie adds its Active Job adapter to config.rails.skippable_job_adapters, so sentry-rails skips those jobs unless the user removes the adapter from that list.
  • When sentry-rails owns the adapter (Sentry::Rails.active_job_owns_adapter?), the adapter gem only isolates the hub and continues the trace, and leaves error and span reporting to sentry-rails.
  • Flipping the default changes which integration reports Active Job errors and spans for existing Sidekiq, Resque, and Delayed Job users, so it is a breaking change.

Related: getsentry/sentry-ruby#3130, getsentry/sentry-ruby#3134, getsentry/sentry-ruby#3145, getsentry/sentry-ruby#3173

Peter Solnica confirmed this was the intended direction when the opt-in landed.

via @dingsdax.

--

View Session [Sentry]

主要语言
Ruby
星标
990
派生
553
平均合并
1 天 19 小时
30 天内合并 PR
31

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

getsentry/sentry-ruby 的其他 Issue

查看 getsentry/sentry-ruby 的全部 Issue

相似的 Issue

更多 Ruby Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。