Report Active Job jobs through sentry-rails by default

Abierto
#3,222 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
ruby

Línea de trabajo

Read the related changes in getsentry/sentry-ruby#3130, #3134, #3145, and #3173, then locate each adapter's Railtie and its handling of Sentry::Rails.active_job_owns_adapter?. Update Sidekiq, Resque, and Delayed Job so Active Job reporting defaults to sentry-rails ownership while preserving the documented opt-out behavior. Verify the adapter and Rails integration tests cover error and span reporting; the issue identifies no test files.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

active_job breaking change Next Major sentry-delayed_job sentry-rails sentry-resque sentry-sidekiq

Since 7.3.0, Sidekiq, Resque, and Delayed Job can hand their Active Job jobs to sentry-rails instead of reporting them through their own integration. This is opt-in today. In the next major, sentry-rails should own Active Job reporting for these adapters by default.

  • Each adapter's Railtie adds its Active Job adapter to config.rails.skippable_job_adapters, so sentry-rails skips those jobs unless the user removes the adapter from that list.
  • When sentry-rails owns the adapter (Sentry::Rails.active_job_owns_adapter?), the adapter gem only isolates the hub and continues the trace, and leaves error and span reporting to sentry-rails.
  • Flipping the default changes which integration reports Active Job errors and spans for existing Sidekiq, Resque, and Delayed Job users, so it is a breaking change.

Related: getsentry/sentry-ruby#3130, getsentry/sentry-ruby#3134, getsentry/sentry-ruby#3145, getsentry/sentry-ruby#3173

Peter Solnica confirmed this was the intended direction when the opt-in landed.

via @dingsdax.

--

View Session [Sentry]

Lenguaje dominante
Ruby
Estrellas
990
Forks
553
Merge medio
1 d 19 h
PR fusionados (30 d)
31

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de getsentry/sentry-ruby

Todos los issues de getsentry/sentry-ruby

Issues similares

Más issues de Ruby

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.