Events dropped client-side for size are only logged at debug level and not recorded as lost
维护者通常 2 天内回复
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 76/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- ruby
- 领域
- backend, observability
调研方向
从 sentry-ruby/lib/sentry/transport.rb 中 Transport#serialize_envelope 附近开始,将丢弃超大项目的路径与 #2885 中新增的 413 处理进行比较。检查丢失事件和已丢弃事件统计是如何记录的,然后为这次丢弃添加相同的可观测性。完成标准是:超大项目以 warn 级别记录日志,并被记录为丢失;验证复现结果中的已丢弃事件不为空。
由索引模型根据 Issue 内容生成。
描述
Issue Description
When an envelope item is still larger than MAX_SERIALIZED_PAYLOAD_SIZE after Envelope::Item#serialize has removed breadcrumbs and reduced the stacktrace, Transport#serialize_envelope skips it with a log_debug and nothing else:
https://github.com/getsentry/sentry-ruby/blob/master/sentry-ruby/lib/sentry/transport.rb#L77-L82
Since the event is never sent, Relay never sees it, so it doesn't show up in the invalid payload stats either. And unlike the 413 path added in #2885, no client report is recorded. With the SDK logger at the usual info level, the event is lost without any trace.
The size reduction doesn't touch extra or contexts, so a large custom payload is enough to hit this. In our case, a scheduled job reported a list of record ids in extra - the list was about 3 MB, and the event never arrived. We only noticed because we knew a report should arrive, and were confused why none did arrive.
#2381 asked for truncation of custom contexts and was declined in favor of server-side handling, with a pointer to the invalid payload stats. That makes sense for truncation, but these events never reach the server, so the stats can't show them. This issue is only about making the drop visible.
Reproduction Steps
require "logger"
gem "sentry-ruby", "7.2.0"
require "sentry-ruby"
Sentry.init do |config|
config.dsn = "http://[email protected]:9/1" # nothing listens here; the event is dropped before any request
config.background_worker_threads = 0
config.sdk_logger = Logger.new($stdout, level: ENV.fetch("LOG_LEVEL", "info"))
end
Sentry.capture_message("Found records", extra: { ids: (1..200_000).to_a })
puts "discarded events: #{Sentry.get_current_client.transport.instance_variable_get(:@discarded_events).inspect}"
Expected Behavior
- The drop is logged at
warnlevel, like the 413 response. - A lost event is recorded (e.g.
record_lost_event(:send_error, item.data_category, num: item.item_count, num_bytes: item.lost_event_byte_size), as in the 413 path), so it shows up in the org's stats.
Actual Behavior
With LOG_LEVEL=info, the script prints only:
discarded events: {}
With LOG_LEVEL=debug, the drop is logged, but still no lost event is recorded:
DEBUG -- sentry: Envelope item [event] is still oversized after size reduction: {event_id: 34, level: 7, timestamp: 22, environment: 13, server_name: 19, modules: 13408, message: 15, user: 2, tags: 2, contexts: 525, extra: 1288904, fingerprint: 2, platform: 6, sdk: 40, type: 7, threads: 1654}
discarded events: {}
Ruby Version
4.0.9
SDK Version
7.2.0
Integration and Its Version
Reproducible with plain sentry-ruby; we noticed it in Rails 8.1 with sentry-rails and sentry-sidekiq 7.2.0.
Sentry Config
No response
- 主要语言
- Ruby
- 星标
- 990
- 派生
- 552
- 平均合并
- 2 天 16 小时
- 30 天内合并 PR
- 29
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
getsentry/sentry-ruby 的其他 Issue
-
Bug Ruby
难度 2/5 1-3 小时 新手友好度 76/100
getsentry/sentry-ruby#3211 · 1 条评论 ·
维护者通常 2 天内回复
-
with_child_span drops spans when blocks exit via break, return, or throw可能已有人在做 @itsrayeedscodespace 于 1 天前认领。 未关闭Bug Ruby Traces Waiting for: Product Owner
难度 2/5 1-3 小时 新手友好度 38/100
getsentry/sentry-ruby#3206 · 1 条评论 ·
维护者通常 2 天内回复
-
Let apps choose how the client IP on events is determined可能已有人在做 @sl0thentr0py 于 11 天前认领。 未关闭Improvement Ruby
getsentry/sentry-ruby#3180 · 2 条评论 · 1 个 reaction · 已指派 1 人 ·
维护者通常 2 天内回复
-
breaking change Next Major
难度 2/5 1-3 小时 新手友好度 58/100
getsentry/sentry-ruby#3176 · 1 条评论 ·
维护者通常 2 天内回复
-
With `register_error_subscriber`, view errors are reported twice: the wrapper by the middleware, and its cause by the error subscriber可能已有人在做 @sl0thentr0py 于 13 天前认领。 未关闭Bug Ruby
难度 4/5 1-2 天 新手友好度 57/100
getsentry/sentry-ruby#3166 · 1 条评论 · 已指派 1 人 ·
维护者通常 2 天内回复
查看 getsentry/sentry-ruby 的全部 Issue
相似的 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 66/100
internetee/registry#2984 ·
维护者通常 6 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
ecosyste-ms/issues#862 ·
维护者通常 1 天内回复
-
Redis Lua error `@user_script:52: ERR value is not an integer or out of range` when `window_size` is configured可能已有人在做 @mimosa 今天认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 67/100
riscv/riscv-unified-db#2829 ·
维护者通常 1 天内回复
-
⛓️ Security Difficulty: Easy Good First Issue Help Wanted ruby Type: Bug
难度 2/5 1-3 小时 新手友好度 82/100
rubyforgood/casa#7404 ·
维护者通常 1 天内回复