Report Active Job jobs through sentry-rails by default

未關閉
#3,222 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
48/100
Issue 類型
功能
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
ruby

研究方向

Read the related changes in getsentry/sentry-ruby#3130, #3134, #3145, and #3173, then locate each adapter's Railtie and its handling of Sentry::Rails.active_job_owns_adapter?. Update Sidekiq, Resque, and Delayed Job so Active Job reporting defaults to sentry-rails ownership while preserving the documented opt-out behavior. Verify the adapter and Rails integration tests cover error and span reporting; the issue identifies no test files.

由索引模型根據 Issue 內容生成。

描述

active_job breaking change Next Major sentry-delayed_job sentry-rails sentry-resque sentry-sidekiq

Since 7.3.0, Sidekiq, Resque, and Delayed Job can hand their Active Job jobs to sentry-rails instead of reporting them through their own integration. This is opt-in today. In the next major, sentry-rails should own Active Job reporting for these adapters by default.

  • Each adapter's Railtie adds its Active Job adapter to config.rails.skippable_job_adapters, so sentry-rails skips those jobs unless the user removes the adapter from that list.
  • When sentry-rails owns the adapter (Sentry::Rails.active_job_owns_adapter?), the adapter gem only isolates the hub and continues the trace, and leaves error and span reporting to sentry-rails.
  • Flipping the default changes which integration reports Active Job errors and spans for existing Sidekiq, Resque, and Delayed Job users, so it is a breaking change.

Related: getsentry/sentry-ruby#3130, getsentry/sentry-ruby#3134, getsentry/sentry-ruby#3145, getsentry/sentry-ruby#3173

Peter Solnica confirmed this was the intended direction when the opt-in landed.

via @dingsdax.

--

View Session [Sentry]

主要語言
Ruby
星號
990
分支
553
平均合併
1 天 19 小時
30 天內合併 PR
31

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

getsentry/sentry-ruby 的其他 Issue

查看 getsentry/sentry-ruby 的全部 Issue

相似的 Issue

更多 Ruby Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。