Does the Options attribute class really need to be sealed?
还没有人认领这个 Issue。
评估
调研方向
未指定文件或测试。首先定位 C# Options/OptionAttribute 声明及其 sealed 修饰符,然后检查属性如何被使用以及测试覆盖情况。完成标准是,项目已就是否支持派生选项属性作出明确且经过审查的决定;如果决定为 yes,则相应更新 API 和测试。
由索引模型根据 Issue 内容生成。
描述
I have been using CommandLineParser for a while now (and it's changed how I build tools -- thank you!) including in a program with ~50 Verbs (and growing), and since many of the Verbs take common options, I was hoping to extend Options to provide common handling of them.
Simple example: if 15 Verbs take a LogFile option, each of which has a long name ("log-file") and a help description, I can do this now by constant strings to keep them consistent, but if I were able to do:
[AttributeUsage(AttributeTargets.Property)]
public class LogFileOptionAttribute : OptionAttribute
{
public LogFileOptionAttribute(bool required = false)
: base("log-file") // I don't use short option names for anything
{
HelpText = "Name of the logfile to use for blah blah blah";
Required = required;
}
}
and then adorn the actual option with:
public class BlahOptions {
...
[LogFileOption]
public string LogFileName {get ; set; }
...
}
I have easily a dozen of these common options. It's not a huge deal to create constant strings:
[Option(OPTION_LOGFILE_NAME, HelpText = OPTION_LOGFILE_HELPTEXT)]
but adding this level of abstraction would be more convenient.
If there's a good reason for this class to be sealed, then so be it, but mine doesn't feel like a ridiculous use case. I may well get to 100 verbs for this tool by the time I'm done.
- 主要语言
- C#
- 星标
- 4.8k
- 派生
- 478
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
commandlineparser/commandline 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
commandlineparser/commandline#951 · 1 条评论 ·
-
难度 1/5 1 小时以内 新手友好度 70/100
commandlineparser/commandline#880 · 2 个 reaction ·
-
难度 5/5 一周以上 新手友好度 45/100
commandlineparser/commandline#952 ·
-
难度 3/5 1-2 天 新手友好度 35/100
commandlineparser/commandline#948 ·
-
难度 5/5 一周以上 新手友好度 35/100
commandlineparser/commandline#947 ·
查看 commandlineparser/commandline 的全部 Issue
相似的 Issue
-
bug frontend good first issue
难度 2/5 1-3 小时 新手友好度 75/100
-
NavigationViewItemAutomationPeer implements IInvokeProvider but never advertises the Invoke pattern 未关闭
难度 2/5 1-3 小时 新手友好度 75/100
unoplatform/uno#24629 ·
-
agentic-workflows Needs: Triage :mag: State: In-PR
难度 2/5 1-3 小时 新手友好度 70/100
-
bug
难度 1/5 1 小时以内 新手友好度 90/100
-
Type: enhancement
难度 2/5 1-3 小时 新手友好度 65/100
apache/arrow-adbc#4809 ·