fix(api): GET /v1/pending lists approval requests whose window has passed

未关闭
#1,043 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
78/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
aws, typescript
领域
api, backend

调研方向

Start with the query and row mapping in cdk/src/handlers/get-pending.ts, then check PR #904 for the agreed expiration rule and PR #1013 for how timeout_s of 0 is handled. Filter expired requests while preserving rows with no automatic deadline. Done means GET /v1/pending omits expired requests and retains requests whose timeout is 0.

由索引模型根据 Issue 内容生成。

描述

bug orchestration
Component

CDK / infrastructure (API handlers)

Describe the bug

GET /v1/pending (bgagent pending) lists approval requests whose window has already passed.

The handler returns every row of the caller whose status is PENDING. It computes expires_at (created_at + timeout_s) for each row, and never compares it with the clock (cdk/src/handlers/get-pending.ts, the query and the mapping that follows it).

Normally the agent ends the wait itself and writes TIMED_OUT, which takes the row out of the list. A stale row is left when the agent can no longer do that: its container is gone, or the task was failed or cancelled while it waited. The row then stays PENDING until DynamoDB's TTL deletes it. The TTL is created_at + timeout_s + 120 s, and DynamoDB deletes expired items lazily, so the row can stay listed long after its window.

Expected behavior

A request whose window has passed is not listed as pending.

Current behavior

The request is listed, with an expires_at in the past. Approving or denying it is refused once the task has left AWAITING_APPROVAL; before that it records a decision that no agent is waiting for.

Reproduction steps
  1. Leave an approval row in status PENDING whose created_at + timeout_s is in the past. On a deployed stack: let a task reach an approval gate, stop its agent (for example by cancelling the task), and wait for the window to pass. On a table without TTL deletion (the emulator tier's tables): write such a row directly.
  2. Call GET /v1/pending as the row's user.
  3. The response contains the request.
Possible solution

Filter out rows whose computed expires_at is in the past in get-pending.ts. The index the handler reads already projects created_at and timeout_s, so this needs no index change.

Two things to check when doing it:

  • Open PR #904 adds a deadline_epoch to the row and makes approve and deny refuse after it. That settles what "expired" means, and the filter should use the same rule.
  • Open PR #1013's writer accepts timeout_s 0 as "no automatic deadline". A filter must keep such rows.
Additional context

Found by the investigation recorded in docs/research/aws-emulator-local-tests.md (pull request for #1041), re-checked on main at 8697c821. It is not fixed by that pull request. No open pull request changes get-pending.ts.

AWS quotas
  • I have reviewed the relevant service quotas (or N/A)
主要语言
TypeScript
星标
173
派生
53
平均合并
2 天 9 小时
30 天内合并 PR
14

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

aws-samples/sample-autonomous-cloud-coding-agents 的其他 Issue

查看 aws-samples/sample-autonomous-cloud-coding-agents 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。