fix(api): GET /v1/pending lists approval requests whose window has passed

Aperta
#1,043 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
78/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
aws, typescript
Ambito
api, backend

Direzione di ricerca

Start with the query and row mapping in cdk/src/handlers/get-pending.ts, then check PR #904 for the agreed expiration rule and PR #1013 for how timeout_s of 0 is handled. Filter expired requests while preserving rows with no automatic deadline. Done means GET /v1/pending omits expired requests and retains requests whose timeout is 0.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug orchestration
Component

CDK / infrastructure (API handlers)

Describe the bug

GET /v1/pending (bgagent pending) lists approval requests whose window has already passed.

The handler returns every row of the caller whose status is PENDING. It computes expires_at (created_at + timeout_s) for each row, and never compares it with the clock (cdk/src/handlers/get-pending.ts, the query and the mapping that follows it).

Normally the agent ends the wait itself and writes TIMED_OUT, which takes the row out of the list. A stale row is left when the agent can no longer do that: its container is gone, or the task was failed or cancelled while it waited. The row then stays PENDING until DynamoDB's TTL deletes it. The TTL is created_at + timeout_s + 120 s, and DynamoDB deletes expired items lazily, so the row can stay listed long after its window.

Expected behavior

A request whose window has passed is not listed as pending.

Current behavior

The request is listed, with an expires_at in the past. Approving or denying it is refused once the task has left AWAITING_APPROVAL; before that it records a decision that no agent is waiting for.

Reproduction steps
  1. Leave an approval row in status PENDING whose created_at + timeout_s is in the past. On a deployed stack: let a task reach an approval gate, stop its agent (for example by cancelling the task), and wait for the window to pass. On a table without TTL deletion (the emulator tier's tables): write such a row directly.
  2. Call GET /v1/pending as the row's user.
  3. The response contains the request.
Possible solution

Filter out rows whose computed expires_at is in the past in get-pending.ts. The index the handler reads already projects created_at and timeout_s, so this needs no index change.

Two things to check when doing it:

  • Open PR #904 adds a deadline_epoch to the row and makes approve and deny refuse after it. That settles what "expired" means, and the filter should use the same rule.
  • Open PR #1013's writer accepts timeout_s 0 as "no automatic deadline". A filter must keep such rows.
Additional context

Found by the investigation recorded in docs/research/aws-emulator-local-tests.md (pull request for #1041), re-checked on main at 8697c821. It is not fixed by that pull request. No open pull request changes get-pending.ts.

AWS quotas
  • I have reviewed the relevant service quotas (or N/A)
Lingua principale
TypeScript
Stelle
173
Fork
53
Merge medio
2g 9h
PR unite (30g)
14

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di aws-samples/sample-autonomous-cloud-coding-agents

Tutte le issue di aws-samples/sample-autonomous-cloud-coding-agents

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.