fix(api): GET /v1/pending lists approval requests whose window has passed
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 78/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- aws, typescript
Línea de trabajo
Start with the query and row mapping in cdk/src/handlers/get-pending.ts, then check PR #904 for the agreed expiration rule and PR #1013 for how timeout_s of 0 is handled. Filter expired requests while preserving rows with no automatic deadline. Done means GET /v1/pending omits expired requests and retains requests whose timeout is 0.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Component
CDK / infrastructure (API handlers)
Describe the bug
GET /v1/pending (bgagent pending) lists approval requests whose window has already passed.
The handler returns every row of the caller whose status is PENDING. It computes expires_at (created_at + timeout_s) for each row, and never compares it with the clock (cdk/src/handlers/get-pending.ts, the query and the mapping that follows it).
Normally the agent ends the wait itself and writes TIMED_OUT, which takes the row out of the list. A stale row is left when the agent can no longer do that: its container is gone, or the task was failed or cancelled while it waited. The row then stays PENDING until DynamoDB's TTL deletes it. The TTL is created_at + timeout_s + 120 s, and DynamoDB deletes expired items lazily, so the row can stay listed long after its window.
Expected behavior
A request whose window has passed is not listed as pending.
Current behavior
The request is listed, with an expires_at in the past. Approving or denying it is refused once the task has left AWAITING_APPROVAL; before that it records a decision that no agent is waiting for.
Reproduction steps
- Leave an approval row in status
PENDINGwhosecreated_at + timeout_sis in the past. On a deployed stack: let a task reach an approval gate, stop its agent (for example by cancelling the task), and wait for the window to pass. On a table without TTL deletion (the emulator tier's tables): write such a row directly. - Call
GET /v1/pendingas the row's user. - The response contains the request.
Possible solution
Filter out rows whose computed expires_at is in the past in get-pending.ts. The index the handler reads already projects created_at and timeout_s, so this needs no index change.
Two things to check when doing it:
- Open PR #904 adds a
deadline_epochto the row and makes approve and deny refuse after it. That settles what "expired" means, and the filter should use the same rule. - Open PR #1013's writer accepts
timeout_s0 as "no automatic deadline". A filter must keep such rows.
Additional context
Found by the investigation recorded in docs/research/aws-emulator-local-tests.md (pull request for #1041), re-checked on main at 8697c821. It is not fixed by that pull request. No open pull request changes get-pending.ts.
AWS quotas
- I have reviewed the relevant service quotas (or N/A)
- Lenguaje dominante
- TypeScript
- Estrellas
- 173
- Forks
- 53
- Merge medio
- 2 d 9 h
- PR fusionados (30 d)
- 14
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de aws-samples/sample-autonomous-cloud-coding-agents
-
bug infra-cdk
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
aws-samples/sample-autonomous-cloud-coding-agents#1044 ·
Los mantenedores suelen responder en 1 día
-
cdk: support Docker-compatible engines such as Finch (clean:disk hard-codes docker)Posiblemente ocupada @alvarohare la tomó hace 19 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
aws-samples/sample-autonomous-cloud-coding-agents#969 · 1 comentario · 1 reacción · 1 asignado ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
aws-samples/sample-autonomous-cloud-coding-agents#968 ·
Los mantenedores suelen responder en 1 día
-
documentation P2 security
Dificultad 2/5 1-2 días Aptitud para principiantes 74/100
aws-samples/sample-autonomous-cloud-coding-agents#793 ·
Los mantenedores suelen responder en 1 día
-
Docs: How to clear previously set attributes for a blueprintQuizá libre de nuevo @rkumarus-aws la tomó hace 77 días y no hay ningún pull request abierto. Abiertodocumentation
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
aws-samples/sample-autonomous-cloud-coding-agents#767 · 2 comentarios ·
Los mantenedores suelen responder en 1 día
Todos los issues de aws-samples/sample-autonomous-cloud-coding-agents
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 67/100
ilan-pinto/roaring-lions#1552 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
bug: [React Native/Android] KeepAliveService never starts when CAMERA is not granted (Android 14+)Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
cloudflare/realtimekit-ui#208 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
usebruno/bruno-vscode#235 ·
Los mantenedores suelen responder en 3 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día