Cloudflare Workers (nodejs_compat): SignedDataVerifier passes with online checks; two non-crypto blockers remain

未关闭
#476 1 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

@vishalhabib99 已经在做这个了。

开始于 2026年11月13日。

  • #479 来自 @vishalhabib99 —— 未关闭
  • #480 来自 @Preeternal —— 未关闭

评估

难度
4/5
预计耗时
3-5 天
新手友好度
32/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃

调研方向

Start from the OCSP request path — follow where node-fetch is imported and where fetch(url, { timeout }) and response.buffer() are used — and replace them with the global fetch plus AbortSignal.timeout(30000) and Buffer.from(await response.arrayBuffer()). For the import-time randomness, find where jsrsasign is statically imported and move it to a lazy dynamic import inside the async verification methods. The existing test should validate a real chain with OCSP is the check: done means it still passes on Node and a Worker with nodejs_compat boots without a global-scope error.

由索引模型根据 Issue 内容生成。

描述

In #255 you asked to be told if a runtime such as Cloudflare Workers now has the crypto needed to verify signed data. We tested it, and it does. Only two small issues block it, and neither involves the crypto.

What we measured

2026-10-23, @apple/app-store-server-library 3.1.0, wrangler 4.149.0 (workerd 1.20261006.1), compatibility_date = "2026-10-01", compatibility_flags = ["nodejs_compat"]. Node v24 was the control.

Check Cloudflare edge (NRT), 3 runs Node v24
Real Apple chain with OCSP (enableOnlineChecks = true). We used the certificates and date from this repo's test should validate a real chain with OCSP passes (116–146 ms) passes (199–216 ms)
verifyAndDecodeTransaction on a JWS signed by a test chain (online checks off) passes passes
Same JWS with its payload tampered rejected rejected

The library's use of node:crypto (X509Certificate, signature verification, hashing) worked as-is under nodejs_compat.

What blocked it

  1. jsrsasign generates random values at import time. When the module loads, it calls crypto.getRandomValues. Workers do not allow random generation in global scope (Disallowed operation called within global scope), so a static import stops the Worker from starting. Our workaround is a dynamic import() inside the request handler.
  2. The OCSP request relies on node-fetch v2-only APIs: fetch(url, { timeout }) and response.buffer(). On Workers, the bundler replaces node-fetch with a polyfill that forwards to the platform fetch. That polyfill has neither API, and the call fails with (0 , node_fetch_1.default) is not a function. Our workaround is to alias node-fetch to a wrapper of about 30 lines.

Suggestion

For (2), the OCSP request could use the global fetch (Node 18+) with signal: AbortSignal.timeout(30000), and read the body with Buffer.from(await response.arrayBuffer()). Because the abort signal also covers reading the body, I think this would also fix #455.

For (1), #472 is one approach (it replaces jsrsasign). A smaller change would be to load jsrsasign lazily in the verification path, since those methods are already async.

Note for local testing

wrangler dev --local sends CF-Worker: example.com on outgoing requests, and Apple's OCSP responder answers 403 to that value. Requests with no header, or with other values (foo.com, workers.dev), get 200. A deployed Worker gets 200 too. This only matters when testing OCSP locally. --local-upstream <your-domain> avoids it.

主要语言
TypeScript
星标
388
派生
88
PR 合并指标
30 天内没有已合并 PR

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

apple/app-store-server-library-node 的其他 Issue

查看 apple/app-store-server-library-node 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。