Cloudflare Workers (nodejs_compat): SignedDataVerifier passes with online checks; two non-crypto blockers remain

Aperta
#476 1 commento 1 reazione 0 assegnatari Vedi su GitHub

@vishalhabib99 ci sta già lavorando.

Dal 13/11/2026.

  • #479 di @vishalhabib99 — aperta
  • #480 di @Preeternal — aperta

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
32/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
javascript, node.js, typescript

Direzione di ricerca

Start from the OCSP request path — follow where node-fetch is imported and where fetch(url, { timeout }) and response.buffer() are used — and replace them with the global fetch plus AbortSignal.timeout(30000) and Buffer.from(await response.arrayBuffer()). For the import-time randomness, find where jsrsasign is statically imported and move it to a lazy dynamic import inside the async verification methods. The existing test should validate a real chain with OCSP is the check: done means it still passes on Node and a Worker with nodejs_compat boots without a global-scope error.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

In #255 you asked to be told if a runtime such as Cloudflare Workers now has the crypto needed to verify signed data. We tested it, and it does. Only two small issues block it, and neither involves the crypto.

What we measured

2026-10-23, @apple/app-store-server-library 3.1.0, wrangler 4.149.0 (workerd 1.20261006.1), compatibility_date = "2026-10-01", compatibility_flags = ["nodejs_compat"]. Node v24 was the control.

Check Cloudflare edge (NRT), 3 runs Node v24
Real Apple chain with OCSP (enableOnlineChecks = true). We used the certificates and date from this repo's test should validate a real chain with OCSP passes (116–146 ms) passes (199–216 ms)
verifyAndDecodeTransaction on a JWS signed by a test chain (online checks off) passes passes
Same JWS with its payload tampered rejected rejected

The library's use of node:crypto (X509Certificate, signature verification, hashing) worked as-is under nodejs_compat.

What blocked it

  1. jsrsasign generates random values at import time. When the module loads, it calls crypto.getRandomValues. Workers do not allow random generation in global scope (Disallowed operation called within global scope), so a static import stops the Worker from starting. Our workaround is a dynamic import() inside the request handler.
  2. The OCSP request relies on node-fetch v2-only APIs: fetch(url, { timeout }) and response.buffer(). On Workers, the bundler replaces node-fetch with a polyfill that forwards to the platform fetch. That polyfill has neither API, and the call fails with (0 , node_fetch_1.default) is not a function. Our workaround is to alias node-fetch to a wrapper of about 30 lines.

Suggestion

For (2), the OCSP request could use the global fetch (Node 18+) with signal: AbortSignal.timeout(30000), and read the body with Buffer.from(await response.arrayBuffer()). Because the abort signal also covers reading the body, I think this would also fix #455.

For (1), #472 is one approach (it replaces jsrsasign). A smaller change would be to load jsrsasign lazily in the verification path, since those methods are already async.

Note for local testing

wrangler dev --local sends CF-Worker: example.com on outgoing requests, and Apple's OCSP responder answers 403 to that value. Requests with no header, or with other values (foo.com, workers.dev), get 200. A deployed Worker gets 200 too. This only matters when testing OCSP locally. --local-upstream <your-domain> avoids it.

Lingua principale
TypeScript
Stelle
388
Fork
88
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di apple/app-store-server-library-node

Tutte le issue di apple/app-store-server-library-node

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.