Cloudflare Workers (nodejs_compat): SignedDataVerifier passes with online checks; two non-crypto blockers remain

Abierto
#476 1 comentario 1 reacción 0 asignados Ver en GitHub

@vishalhabib99 ya está trabajando en esto.

Desde el 13/11/2026.

  • #479 de @vishalhabib99 — abierto
  • #480 de @Preeternal — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
32/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
javascript, node.js, typescript

Línea de trabajo

Start from the OCSP request path — follow where node-fetch is imported and where fetch(url, { timeout }) and response.buffer() are used — and replace them with the global fetch plus AbortSignal.timeout(30000) and Buffer.from(await response.arrayBuffer()). For the import-time randomness, find where jsrsasign is statically imported and move it to a lazy dynamic import inside the async verification methods. The existing test should validate a real chain with OCSP is the check: done means it still passes on Node and a Worker with nodejs_compat boots without a global-scope error.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

In #255 you asked to be told if a runtime such as Cloudflare Workers now has the crypto needed to verify signed data. We tested it, and it does. Only two small issues block it, and neither involves the crypto.

What we measured

2026-10-23, @apple/app-store-server-library 3.1.0, wrangler 4.149.0 (workerd 1.20261006.1), compatibility_date = "2026-10-01", compatibility_flags = ["nodejs_compat"]. Node v24 was the control.

Check Cloudflare edge (NRT), 3 runs Node v24
Real Apple chain with OCSP (enableOnlineChecks = true). We used the certificates and date from this repo's test should validate a real chain with OCSP passes (116–146 ms) passes (199–216 ms)
verifyAndDecodeTransaction on a JWS signed by a test chain (online checks off) passes passes
Same JWS with its payload tampered rejected rejected

The library's use of node:crypto (X509Certificate, signature verification, hashing) worked as-is under nodejs_compat.

What blocked it

  1. jsrsasign generates random values at import time. When the module loads, it calls crypto.getRandomValues. Workers do not allow random generation in global scope (Disallowed operation called within global scope), so a static import stops the Worker from starting. Our workaround is a dynamic import() inside the request handler.
  2. The OCSP request relies on node-fetch v2-only APIs: fetch(url, { timeout }) and response.buffer(). On Workers, the bundler replaces node-fetch with a polyfill that forwards to the platform fetch. That polyfill has neither API, and the call fails with (0 , node_fetch_1.default) is not a function. Our workaround is to alias node-fetch to a wrapper of about 30 lines.

Suggestion

For (2), the OCSP request could use the global fetch (Node 18+) with signal: AbortSignal.timeout(30000), and read the body with Buffer.from(await response.arrayBuffer()). Because the abort signal also covers reading the body, I think this would also fix #455.

For (1), #472 is one approach (it replaces jsrsasign). A smaller change would be to load jsrsasign lazily in the verification path, since those methods are already async.

Note for local testing

wrangler dev --local sends CF-Worker: example.com on outgoing requests, and Apple's OCSP responder answers 403 to that value. Requests with no header, or with other values (foo.com, workers.dev), get 200. A deployed Worker gets 200 too. This only matters when testing OCSP locally. --local-upstream <your-domain> avoids it.

Lenguaje dominante
TypeScript
Estrellas
388
Forks
88
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apple/app-store-server-library-node

Todos los issues de apple/app-store-server-library-node

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.