Decide: should confirming a manual payment renew an active membership?

未关闭
#2,137 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
15/100
Issue 类型
功能
描述清晰度
需要澄清
活跃度
活跃
技术栈
php, wordpress
领域
payments

调研方向

Start with the confirm_membership toggle's v-if in inc/admin-pages/class-payment-edit-admin-page.php (around line 1193) and the renewal branch in handle_save() in the same file. The active renewal row of test_manual_confirmation_period shows the current behaviour. This is a maintainer decision, so the work is done only once the desired rule for active memberships is settled; any build must extend the period exactly once.

由索引模型根据 Issue 内容生成。

描述

enhancement hold-for-review no-auto-dispatch origin:interactive status:available

Decision needed

Should confirming a pending payment renew an active manual membership?

Source: review comment on PR #2133 by @coderabbitai. Not a defect in that PR; main behaves the same way.

Premise check

Correct. An administrator cannot renew an active manually billed membership by confirming its payment in the UI. The "Activate Membership?" toggle in the payment editor is hidden when the membership is active or trialing, so the renewal branch of handle_save() is never reached from the page for those memberships.

  • Toggle visibility: inc/admin-pages/class-payment-edit-admin-page.php, the confirm_membership field's v-if (around line 1193).
  • Renewal branch: handle_save() in the same file calls $membership->renew(false, Membership_Status::ACTIVE) for a non-initial payment.
  • The branch works when confirm_membership is posted: the active renewal row of Payment_Edit_Admin_Page_Test::test_manual_confirmation_period passes.
  • On main the toggle is shown for pending memberships only, so this is not new.

Analysis

  • Manual-gateway renewal payments are created by an administrator (inc/admin-pages/class-payment-list-admin-page.php:208 and :461). Nothing creates them at expiry. The only automatic creators are the Stripe and PayPal webhooks and the migrator.
  • Showing the toggle for active memberships would let one confirmation extend the plan's period by a billing cycle. If the administrator has also moved the expiration by hand, that extends it twice.
  • A pending payment is not necessarily a renewal. An administrator can create one with custom line items for something else, and confirming it with the toggle on would still renew. The cart type that identifies add-ons and upgrades is stored only for payments created by checkout, so it cannot tell these apart.
  • Add-on payments already lift a hold without extending the period (#2133), so any new rule must keep that.

Recommended path

Keep today's behaviour and document that an active manual membership is extended by editing its expiration. If maintainers want one-click renewal, show the toggle for an active membership only when the payment has a plan line item, and require the administrator to confirm the new expiration date in the same form.

Verification, if this is built

  • A pending payment with a plan line item on an active membership: the toggle appears, confirming extends the expiration by one cycle exactly once, and a repeated save does not extend again.
  • A pending payment with only custom line items: no toggle.
  • Existing rows of test_manual_confirmation_period keep passing.

aidevops.sh v3.39.189 plugin for OpenCode

主要语言
PHP
星标
219
派生
88
平均合并
1 天 7 小时
30 天内合并 PR
58

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

Ultimate-Multisite/ultimate-multisite 的其他 Issue

查看 Ultimate-Multisite/ultimate-multisite 的全部 Issue

相似的 Issue

更多 PHP Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。