security(sso): apply mapped-domain token policy to admin-bar magic links
维护者通常 1 天内回复
评估
这个 Issue 还没有评估数据。
描述
Problem
Follow-up to GHSA-qh2w-5cww-9wxr (fixed in 2.19.0 by #2119). Admin-bar magic links still send network admins to customer mapped domains with a login token in the URL. Whoever controls the domain's DNS can capture the token and replay it for a network admin session.
An attacker cannot force this: the link needs a nonce-protected click by the admin. But the customer still receives a network-wide credential whenever an admin visits their site this way.
Files
inc/sso/class-admin-bar-magic-links.php: around line 184, access is allowed foris_super_admin() || is_user_member_of_blog().inc/sso/class-magic-link.php:verify_user_site_access()(around line 800) also allows any super admin on any site.
Reference pattern
Use the host policy added in #2119, SSO::can_use_cookie_less_sso_token() in inc/sso/class-sso.php:
- Hosts the network owner controls (network domain, its subdomains, main-site domains): no change.
- Customer mapped domains: no token for users with
is_super_admin()/manage_network. Non-admins must be members of the site. - Filter
wu_sso_allow_cookie_less_tokenlets operators relax it.
Options: make that check reusable (public or a shared helper) and apply it when magic links are generated and redeemed. When a network admin targets a customer mapped domain, send them to that domain's login page instead of minting a token.
Verification
vendor/bin/phpunit --filter Magic_Link, plus the admin-bar magic-link tests, pass.- New test: a super admin requesting a magic link for a subsite with an active mapped domain gets no token. Fixture pattern:
create_customer_mapped_site()intests/WP_Ultimo/SSO/SSO_Coverage_Test.php. - Magic links on network subdomains, and for site members, still work.
Files Scope
- EDIT:
inc/sso/class-admin-bar-magic-links.php - EDIT:
inc/sso/class-magic-link.php - EDIT:
inc/sso/class-sso.php - EDIT:
tests/WP_Ultimo/SSO/SSO_Coverage_Test.php
aidevops.sh v3.39.189 plugin for OpenCode
- 主要语言
- PHP
- 星标
- 219
- 派生
- 88
- 平均合并
- 1 天 7 小时
- 30 天内合并 PR
- 58
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
Ultimate-Multisite/ultimate-multisite 的其他 Issue
-
bug origin:interactive status:available
难度 2/5 1-3 小时 新手友好度 62/100
Ultimate-Multisite/ultimate-multisite#2131 ·
维护者通常 1 天内回复
-
bug hold-for-review no-auto-dispatch origin:interactive status:available
难度 3/5 1-2 天 新手友好度 20/100
Ultimate-Multisite/ultimate-multisite#2140 ·
维护者通常 1 天内回复
-
enhancement hold-for-review no-auto-dispatch origin:interactive status:available
难度 5/5 一周以上 新手友好度 15/100
Ultimate-Multisite/ultimate-multisite#2137 ·
维护者通常 1 天内回复
-
fix: customer site lists stop at 100 sites (BerlinDB default number)可能已有人在做 @superdav42 今天认领。 未关闭auto-dispatch bug origin:interactive status:in-review tier:standard
Ultimate-Multisite/ultimate-multisite#2136 · 5 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
-
fix: My Sites, Limits and Current Membership columns above 3 collapse to one column (missing grid utilities)可能已有人在做 @superdav42 今天认领。 未关闭auto-dispatch bug origin:interactive status:in-review tier:standard
Ultimate-Multisite/ultimate-multisite#2134 · 5 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
查看 Ultimate-Multisite/ultimate-multisite 的全部 Issue
相似的 Issue
-
35-feedback
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
bug good first issue
难度 2/5 1-3 小时 新手友好度 78/100
quantum-php/framework#692 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 70/100
ajeetraina/awesome-docker-sbx#559 ·
-
PHP 8.6 support未关闭
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 2/5 1-3 小时 新手友好度 62/100
pantaflex44/Tiquettes#116 · 1 条评论 ·