Decide: should confirming a manual payment renew an active membership?

Ouverte
#2,137 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
5/5
Temps estimé
Plus d'une semaine
Accessibilité débutants
15/100
Type d'issue
Fonctionnalité
Clarté
À clarifier
Activité
Active
Stack technique
php, wordpress
Domaine
payments

Piste de recherche

Start with the confirm_membership toggle's v-if in inc/admin-pages/class-payment-edit-admin-page.php (around line 1193) and the renewal branch in handle_save() in the same file. The active renewal row of test_manual_confirmation_period shows the current behaviour. This is a maintainer decision, so the work is done only once the desired rule for active memberships is settled; any build must extend the period exactly once.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

enhancement hold-for-review no-auto-dispatch origin:interactive status:available

Decision needed

Should confirming a pending payment renew an active manual membership?

Source: review comment on PR #2133 by @coderabbitai. Not a defect in that PR; main behaves the same way.

Premise check

Correct. An administrator cannot renew an active manually billed membership by confirming its payment in the UI. The "Activate Membership?" toggle in the payment editor is hidden when the membership is active or trialing, so the renewal branch of handle_save() is never reached from the page for those memberships.

  • Toggle visibility: inc/admin-pages/class-payment-edit-admin-page.php, the confirm_membership field's v-if (around line 1193).
  • Renewal branch: handle_save() in the same file calls $membership->renew(false, Membership_Status::ACTIVE) for a non-initial payment.
  • The branch works when confirm_membership is posted: the active renewal row of Payment_Edit_Admin_Page_Test::test_manual_confirmation_period passes.
  • On main the toggle is shown for pending memberships only, so this is not new.

Analysis

  • Manual-gateway renewal payments are created by an administrator (inc/admin-pages/class-payment-list-admin-page.php:208 and :461). Nothing creates them at expiry. The only automatic creators are the Stripe and PayPal webhooks and the migrator.
  • Showing the toggle for active memberships would let one confirmation extend the plan's period by a billing cycle. If the administrator has also moved the expiration by hand, that extends it twice.
  • A pending payment is not necessarily a renewal. An administrator can create one with custom line items for something else, and confirming it with the toggle on would still renew. The cart type that identifies add-ons and upgrades is stored only for payments created by checkout, so it cannot tell these apart.
  • Add-on payments already lift a hold without extending the period (#2133), so any new rule must keep that.

Recommended path

Keep today's behaviour and document that an active manual membership is extended by editing its expiration. If maintainers want one-click renewal, show the toggle for an active membership only when the payment has a plan line item, and require the administrator to confirm the new expiration date in the same form.

Verification, if this is built

  • A pending payment with a plan line item on an active membership: the toggle appears, confirming extends the expiration by one cycle exactly once, and a repeated save does not extend again.
  • A pending payment with only custom line items: no toggle.
  • Existing rows of test_manual_confirmation_period keep passing.

aidevops.sh v3.39.189 plugin for OpenCode

Langage dominant
PHP
Étoiles
219
Forks
88
Merge moyen
1 j 7 h
PR mergées (30 j)
58

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de Ultimate-Multisite/ultimate-multisite

Toutes les issues de Ultimate-Multisite/ultimate-multisite

Issues similaires

Plus d'issues PHP

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.