Decide: should confirming a manual payment renew an active membership?

Đang mở
#2,137 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
5/5
Thời gian dự kiến
Hơn một tuần
Mức phù hợp với người mới
15/100
Loại issue
Tính năng
Độ rõ ràng
Cần làm rõ
Mức độ hoạt động
Sôi nổi
Công nghệ
php, wordpress
Lĩnh vực
payments

Hướng nghiên cứu

Start with the confirm_membership toggle's v-if in inc/admin-pages/class-payment-edit-admin-page.php (around line 1193) and the renewal branch in handle_save() in the same file. The active renewal row of test_manual_confirmation_period shows the current behaviour. This is a maintainer decision, so the work is done only once the desired rule for active memberships is settled; any build must extend the period exactly once.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

enhancement hold-for-review no-auto-dispatch origin:interactive status:available

Decision needed

Should confirming a pending payment renew an active manual membership?

Source: review comment on PR #2133 by @coderabbitai. Not a defect in that PR; main behaves the same way.

Premise check

Correct. An administrator cannot renew an active manually billed membership by confirming its payment in the UI. The "Activate Membership?" toggle in the payment editor is hidden when the membership is active or trialing, so the renewal branch of handle_save() is never reached from the page for those memberships.

  • Toggle visibility: inc/admin-pages/class-payment-edit-admin-page.php, the confirm_membership field's v-if (around line 1193).
  • Renewal branch: handle_save() in the same file calls $membership->renew(false, Membership_Status::ACTIVE) for a non-initial payment.
  • The branch works when confirm_membership is posted: the active renewal row of Payment_Edit_Admin_Page_Test::test_manual_confirmation_period passes.
  • On main the toggle is shown for pending memberships only, so this is not new.

Analysis

  • Manual-gateway renewal payments are created by an administrator (inc/admin-pages/class-payment-list-admin-page.php:208 and :461). Nothing creates them at expiry. The only automatic creators are the Stripe and PayPal webhooks and the migrator.
  • Showing the toggle for active memberships would let one confirmation extend the plan's period by a billing cycle. If the administrator has also moved the expiration by hand, that extends it twice.
  • A pending payment is not necessarily a renewal. An administrator can create one with custom line items for something else, and confirming it with the toggle on would still renew. The cart type that identifies add-ons and upgrades is stored only for payments created by checkout, so it cannot tell these apart.
  • Add-on payments already lift a hold without extending the period (#2133), so any new rule must keep that.

Recommended path

Keep today's behaviour and document that an active manual membership is extended by editing its expiration. If maintainers want one-click renewal, show the toggle for an active membership only when the payment has a plan line item, and require the administrator to confirm the new expiration date in the same form.

Verification, if this is built

  • A pending payment with a plan line item on an active membership: the toggle appears, confirming extends the expiration by one cycle exactly once, and a repeated save does not extend again.
  • A pending payment with only custom line items: no toggle.
  • Existing rows of test_manual_confirmation_period keep passing.

aidevops.sh v3.39.189 plugin for OpenCode

Ngôn ngữ chính
PHP
Star
219
Fork
88
Merge trung bình
1 ngày 7 giờ
Pull request đã merge (30 ngày)
58

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của Ultimate-Multisite/ultimate-multisite

Tất cả issue của Ultimate-Multisite/ultimate-multisite

Issue tương tự

Thêm issue về PHP

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.