security(sso): apply mapped-domain token policy to admin-bar magic links

Abierto
#2,125 5 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@superdav42 ya está trabajando en esto.

Desde el 20/11/2026.

  • #2129 de @superdav42 — abierto

Evaluación

Este issue todavía no se ha evaluado.

Descripción

auto-dispatch origin:interactive status:in-review tier:standard

Problem

Follow-up to GHSA-qh2w-5cww-9wxr (fixed in 2.19.0 by #2119). Admin-bar magic links still send network admins to customer mapped domains with a login token in the URL. Whoever controls the domain's DNS can capture the token and replay it for a network admin session.

An attacker cannot force this: the link needs a nonce-protected click by the admin. But the customer still receives a network-wide credential whenever an admin visits their site this way.

Files

  • inc/sso/class-admin-bar-magic-links.php: around line 184, access is allowed for is_super_admin() || is_user_member_of_blog().
  • inc/sso/class-magic-link.php: verify_user_site_access() (around line 800) also allows any super admin on any site.

Reference pattern

Use the host policy added in #2119, SSO::can_use_cookie_less_sso_token() in inc/sso/class-sso.php:

  • Hosts the network owner controls (network domain, its subdomains, main-site domains): no change.
  • Customer mapped domains: no token for users with is_super_admin() / manage_network. Non-admins must be members of the site.
  • Filter wu_sso_allow_cookie_less_token lets operators relax it.

Options: make that check reusable (public or a shared helper) and apply it when magic links are generated and redeemed. When a network admin targets a customer mapped domain, send them to that domain's login page instead of minting a token.

Verification

  • vendor/bin/phpunit --filter Magic_Link, plus the admin-bar magic-link tests, pass.
  • New test: a super admin requesting a magic link for a subsite with an active mapped domain gets no token. Fixture pattern: create_customer_mapped_site() in tests/WP_Ultimo/SSO/SSO_Coverage_Test.php.
  • Magic links on network subdomains, and for site members, still work.
Files Scope
  • EDIT: inc/sso/class-admin-bar-magic-links.php
  • EDIT: inc/sso/class-magic-link.php
  • EDIT: inc/sso/class-sso.php
  • EDIT: tests/WP_Ultimo/SSO/SSO_Coverage_Test.php

aidevops.sh v3.39.189 plugin for OpenCode

Lenguaje dominante
PHP
Estrellas
219
Forks
88
Merge medio
1 d 7 h
PR fusionados (30 d)
58

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Ultimate-Multisite/ultimate-multisite

Todos los issues de Ultimate-Multisite/ultimate-multisite

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.