security(sso): apply mapped-domain token policy to admin-bar magic links

Aperta
#2,125 5 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@superdav42 ci sta già lavorando.

Dal 20/11/2026.

  • #2129 di @superdav42 — aperta

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

auto-dispatch origin:interactive status:in-review tier:standard

Problem

Follow-up to GHSA-qh2w-5cww-9wxr (fixed in 2.19.0 by #2119). Admin-bar magic links still send network admins to customer mapped domains with a login token in the URL. Whoever controls the domain's DNS can capture the token and replay it for a network admin session.

An attacker cannot force this: the link needs a nonce-protected click by the admin. But the customer still receives a network-wide credential whenever an admin visits their site this way.

Files

  • inc/sso/class-admin-bar-magic-links.php: around line 184, access is allowed for is_super_admin() || is_user_member_of_blog().
  • inc/sso/class-magic-link.php: verify_user_site_access() (around line 800) also allows any super admin on any site.

Reference pattern

Use the host policy added in #2119, SSO::can_use_cookie_less_sso_token() in inc/sso/class-sso.php:

  • Hosts the network owner controls (network domain, its subdomains, main-site domains): no change.
  • Customer mapped domains: no token for users with is_super_admin() / manage_network. Non-admins must be members of the site.
  • Filter wu_sso_allow_cookie_less_token lets operators relax it.

Options: make that check reusable (public or a shared helper) and apply it when magic links are generated and redeemed. When a network admin targets a customer mapped domain, send them to that domain's login page instead of minting a token.

Verification

  • vendor/bin/phpunit --filter Magic_Link, plus the admin-bar magic-link tests, pass.
  • New test: a super admin requesting a magic link for a subsite with an active mapped domain gets no token. Fixture pattern: create_customer_mapped_site() in tests/WP_Ultimo/SSO/SSO_Coverage_Test.php.
  • Magic links on network subdomains, and for site members, still work.
Files Scope
  • EDIT: inc/sso/class-admin-bar-magic-links.php
  • EDIT: inc/sso/class-magic-link.php
  • EDIT: inc/sso/class-sso.php
  • EDIT: tests/WP_Ultimo/SSO/SSO_Coverage_Test.php

aidevops.sh v3.39.189 plugin for OpenCode

Lingua principale
PHP
Stelle
219
Fork
88
Merge medio
1g 7h
PR unite (30g)
58

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Ultimate-Multisite/ultimate-multisite

Tutte le issue di Ultimate-Multisite/ultimate-multisite

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.