Bring --files/--changed-since to lint_project, validate-scenes and report

未关闭
#121 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
55/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript
领域
tooling

调研方向

Start with the narrowing check and runCommand in src/cli.ts, then inspect src/tools/lint.ts and src/project/changed.ts to trace how file selection reaches lint_project. Read the scene validation and projectReport entry points to see where the selected paths must be applied, including attached scripts. Done when the CLI commands and MCP tool consistently narrow their work, generated tools are updated, and relevant tests cover the behavior.

由索引模型根据 Issue 内容生成。

描述

enhancement severity: medium

Summary

--files and --changed-since only work with lint, and the lint_project MCP tool has no equivalent. Extend narrowing to lint_project, validate-scenes and report.

Where

  • src/cli.ts:336-341 (rejects narrowing for anything other than lint)
  • src/cli.ts:40-66 (runCommand passes only only to lintProject)
  • src/tools/lint.ts:56-65 (lint_project input is only { path, baseline })

Proposal

  1. Add optional files: string[] and changedSince: string to lint_project, reusing toProjectPaths and changedSince from src/project/changed.ts, then run npm run generate:tools. Effort S.
  2. Pass only into scene validation and projectReport. A scene is included when the scene itself, or a script it attaches, is in the set. Effort M.

Who benefits

Agents that just edited a few files (today they must lint the whole project, or call lint_file per file without project context), and PR CI runs that touch only a few scenes.

Open questions

  • Should a changed .gd pull in every scene that uses it? That needs a reverse index from script to scenes.
  • Fix the silent-drop behaviour of --files first, so the MCP tool does not inherit it.

Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: enhancement|src/cli.ts|changedSince

主要语言
TypeScript
星标
0
派生
6
平均合并
1 天 21 小时
30 天内合并 PR
8

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TMHSDigital/godot-correctness-mcp 的其他 Issue

查看 TMHSDigital/godot-correctness-mcp 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。