Bring --files/--changed-since to lint_project, validate-scenes and report

Abierto
#121 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
55/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
tooling

Línea de trabajo

Start with the narrowing check and runCommand in src/cli.ts, then inspect src/tools/lint.ts and src/project/changed.ts to trace how file selection reaches lint_project. Read the scene validation and projectReport entry points to see where the selected paths must be applied, including attached scripts. Done when the CLI commands and MCP tool consistently narrow their work, generated tools are updated, and relevant tests cover the behavior.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement severity: medium

Summary

--files and --changed-since only work with lint, and the lint_project MCP tool has no equivalent. Extend narrowing to lint_project, validate-scenes and report.

Where

  • src/cli.ts:336-341 (rejects narrowing for anything other than lint)
  • src/cli.ts:40-66 (runCommand passes only only to lintProject)
  • src/tools/lint.ts:56-65 (lint_project input is only { path, baseline })

Proposal

  1. Add optional files: string[] and changedSince: string to lint_project, reusing toProjectPaths and changedSince from src/project/changed.ts, then run npm run generate:tools. Effort S.
  2. Pass only into scene validation and projectReport. A scene is included when the scene itself, or a script it attaches, is in the set. Effort M.

Who benefits

Agents that just edited a few files (today they must lint the whole project, or call lint_file per file without project context), and PR CI runs that touch only a few scenes.

Open questions

  • Should a changed .gd pull in every scene that uses it? That needs a reverse index from script to scenes.
  • Fix the silent-drop behaviour of --files first, so the MCP tool does not inherit it.

Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: enhancement|src/cli.ts|changedSince

Lenguaje dominante
TypeScript
Estrellas
0
Forks
6
Merge medio
1 d 21 h
PR fusionados (30 d)
8

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/godot-correctness-mcp

Todos los issues de TMHSDigital/godot-correctness-mcp

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.