Bring --files/--changed-since to lint_project, validate-scenes and report

Aberta
#121 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 2 dias

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
55/100
Tipo de issue
Funcionalidade
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
typescript
Domínio
tooling

Direção de pesquisa

Start with the narrowing check and runCommand in src/cli.ts, then inspect src/tools/lint.ts and src/project/changed.ts to trace how file selection reaches lint_project. Read the scene validation and projectReport entry points to see where the selected paths must be applied, including attached scripts. Done when the CLI commands and MCP tool consistently narrow their work, generated tools are updated, and relevant tests cover the behavior.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

enhancement severity: medium

Summary

--files and --changed-since only work with lint, and the lint_project MCP tool has no equivalent. Extend narrowing to lint_project, validate-scenes and report.

Where

  • src/cli.ts:336-341 (rejects narrowing for anything other than lint)
  • src/cli.ts:40-66 (runCommand passes only only to lintProject)
  • src/tools/lint.ts:56-65 (lint_project input is only { path, baseline })

Proposal

  1. Add optional files: string[] and changedSince: string to lint_project, reusing toProjectPaths and changedSince from src/project/changed.ts, then run npm run generate:tools. Effort S.
  2. Pass only into scene validation and projectReport. A scene is included when the scene itself, or a script it attaches, is in the set. Effort M.

Who benefits

Agents that just edited a few files (today they must lint the whole project, or call lint_file per file without project context), and PR CI runs that touch only a few scenes.

Open questions

  • Should a changed .gd pull in every scene that uses it? That needs a reverse index from script to scenes.
  • Fix the silent-drop behaviour of --files first, so the MCP tool does not inherit it.

Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: enhancement|src/cli.ts|changedSince

Linguagem predominante
TypeScript
Estrelas
0
Forks
6
Merge médio
1d 21h
PRs com merge (30d)
8

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de TMHSDigital/godot-correctness-mcp

Todas as issues de TMHSDigital/godot-correctness-mcp

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.