16 tools have no handler test; ssh-api test mocks are copied and have drifted
Mantenedores costumam responder em até 1 dia
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 55/100
- Tipo de issue
- Refatoração
- Clareza
- Claramente especificada
- Status de atividade
- Ativa
- Stack de tecnologia
- node.js, typescript
- Domínio
- testing
Direção de pesquisa
Start by reading mcp-server/src/utils/ssh-api.ts around the exported helpers and the checkSSHAvailable reference, then compare it with the hand-written mocks in handlers.test.ts, integration.test.ts and confirm-gates.test.ts. Create one shared mock factory that uses importOriginal() and overrides only execSSH, then migrate one test file at a time and run cd mcp-server && npm install && npm test. Done means every listed tool has at least one handler test, checkSSHAvailable and its mock are gone, and the tests pass against the real helper shapes.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Summary
Sixteen tools have only schema and registration coverage, and each test file hand-writes its own ssh-api mock, which no longer matches the real module.
Where
mcp-server/src/tools/__tests__/handlers.test.ts:3-13, :59-61, :227-241mcp-server/src/tools/__tests__/integration.test.ts:3-28mcp-server/src/tools/__tests__/confirm-gates.test.ts:6-17- mcp-server/src/utils/ssh-api.ts:406-412 (
checkSSHAvailable, unused)
Details
No handler or command test for: adguardQueryLog, aptUpgradable, certList, composePull, containerScan, diskUsage, fail2banStatus, journalLogs, kernelInfo, networkInfo, npmCerts, ntfySend, openPorts, serviceLogs, speedtestResults, ufwStatus. piStatus's node: "all" path is untested.
Mock drift: handlers.test.ts's getNodeConfig returns no port; its nodeSetting ignores per-node env; errorResponse is re-implemented as error.message; TIMEOUTS values are copied; integration still mocks the unused checkSSHAvailable. The fan-out test installs a mockImplementation and resets it only on its last line, so one failed assertion cascades into later tests (vi.clearAllMocks keeps implementations).
Impact
Changes to URLs, token flow, default ports and empty-output messages in these tools would not be caught, and tool tests pass against behavior the real helpers do not have.
Suggested fix
- Add a shared mock helper that spreads
importOriginal()and overrides onlyexecSSH; switch confirm-gates, handlers and integration to it one at a time. - Use
vi.resetAllMocks()(ormockResetinafterEach). - Delete
checkSSHAvailableand its mock. - Handler tests: ntfySend (URL, optional headers, empty-output message, exit 7); certList and npmCerts (login then Bearer GET, non-JSON login); composePull (discovery,
HOMELAB_COMPOSE_FILES,TIMEOUTS.long); piStatusnode: "all"; adguardQueryLog (URL-encodedsearch, defaultlimit=25); serviceLogs and journalLogs (sinceconversion, empty output). - One per-node env test:
HOMELAB_NODES={"nas":{"host":"nas.local","env":{"HOMELAB_ADGUARD_PORT":"3001"}}}uses port 3001 fornode: "nas".
Acceptance criteria
- Every tool has at least one handler test
- Test files share one mock factory based on the real module
Related: #101
Getting started
- Relevant files:
mcp-server/src/tools/__tests__/handlers.test.ts,mcp-server/src/tools/__tests__/integration.test.ts,mcp-server/src/tools/__tests__/confirm-gates.test.ts,mcp-server/src/utils/ssh-api.ts - How to run tests:
cd mcp-server && npm install && npm test(andnpm run typecheck); structure tests:pip install -r requirements-test.txt && pytest tests/ -v - Conventions: see
CLAUDE.mdandCONTRIBUTING.md
Filed by repo-audit/full-audit at 636fefb. Severity: low. Effort: M. audit-key: testing|mcp-server/src/tools|handler-coverage
- Linguagem predominante
- TypeScript
- Estrelas
- 0
- Forks
- 4
- Merge médio
- 10h 16min
- PRs com merge (30d)
- 2
Preparar o ambiente
- Sem Dockerfile nem arquivo Docker Compose
- Tem um modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de TMHSDigital/Home-Lab-Developer-Tools
-
speedtestResults ignores count: /api/speedtest/latest returns one resultTalvez já em andamento @laozhej assumiu há 2 dias. Abertabug severity: low
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 80/100
TMHSDigital/Home-Lab-Developer-Tools#160 ·
Mantenedores costumam responder em até 1 dia
-
Integration tests import tool modules inside tests and can time out under loadTalvez já em andamento @laozhej assumiu há 2 dias. Abertagood first issue severity: low testing
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 25/100
TMHSDigital/Home-Lab-Developer-Tools#174 ·
Mantenedores costumam responder em até 1 dia
-
Grafana dashboard import to complete the export/import round tripTalvez já em andamento @laozhej assumiu hoje. Abertaenhancement severity: low
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 68/100
TMHSDigital/Home-Lab-Developer-Tools#171 ·
Mantenedores costumam responder em até 1 dia
-
enhancement severity: medium
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 72/100
TMHSDigital/Home-Lab-Developer-Tools#159 ·
Mantenedores costumam responder em até 1 dia
-
Add AdGuard local DNS rewrite tools (list, add, delete)Talvez já em andamento @laozhej assumiu há 1 dia. Abertaenhancement severity: medium
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 72/100
TMHSDigital/Home-Lab-Developer-Tools#157 ·
Mantenedores costumam responder em até 1 dia
Todas as issues de TMHSDigital/Home-Lab-Developer-Tools
Issues semelhantes
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster P3
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
openclaw/openclaw#203385 · 1 comentário · 1 reação ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
nwverse/persona#12800 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 80/100
Mantenedores costumam responder em até 1 dia
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 62/100
microsoft/playwright#44289 ·
Mantenedores costumam responder em até 1 dia
-
good first issue
Dificuldade 2/5 Meio dia Facilidade para iniciantes 65/100
Mantenedores costumam responder em até 1 dia