Add unit tests for the Stack rules engine

未关闭
  • 哪里不对？
#29 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
72/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript
领域
game-dev, testing

调研方向

Start with games/stack/logic.ts:104-208 and games/stack/scenes/GameScene.ts:423; the issue lists the rules and edge cases to cover in a new games/stack/logic.test.ts. Check the project's test setup because the issue says no test suite exists, then add tests for the listed behaviors and fix the gravitySeconds boundary defect. Done when the cases pass in CI.

由索引模型根据 Issue 内容生成。

描述

help wanted severity: medium testing

Summary

games/stack/logic.ts is Phaser-free and says in its header that it is easy to test, but has no tests. It is the most branch-heavy pure module in the repo, and it contains one boundary defect that a table test would catch.

Where

  • games/stack/logic.ts:104-208
  • games/stack/logic.ts:207 (gravitySeconds), games/stack/scenes/GameScene.ts:423 (level is uncapped)

Details

gravitySeconds raises a base that goes negative past level 115 to an integer power, so odd levels above 258 return large positive values: gravitySeconds(259) is about 4.68 where 1/60 is expected. It needs roughly 2,580 lines to reach, so it is a low-severity edge.

Suggested fix

Add games/stack/logic.test.ts:

  • emptyBoard() is 22 rows by 10 columns of null, rows are distinct arrays
  • spawn('I') is {rot:0,x:3,y:0}, spawn('O') has x=4; none collide on an empty board
  • Every ROTATIONS[t] has 4 states of 4 cells
  • collides is true for x<0, x>=10, y>=22 and occupied cells; false for cells at y<0
  • tryMove returns null when blocked and does not mutate its input
  • tryRotate on O returns the same object; T rotates both ways; a wall kick from x=-1 lands in bounds; returns null when all five kicks are blocked; I uses its own kick table
  • dropDistance is 20 for a fresh I, O or T and 0 for a resting piece
  • lock reports lock-out for a piece entirely in the hidden rows
  • fullRows and clearRows handle none, one and two rows and keep 22 rows
  • Bag with a seeded RNG yields a permutation of all seven types per run of 7; peek does not consume and works across a refill
  • gravitySeconds is non-increasing and never below 1/60 for levels 1 to 500 (fails today; clamp the base at 0 or cap the level)

Acceptance criteria

  • The cases above pass in CI

Getting started

  • Relevant files: games/stack/logic.ts, games/stack/scenes/GameScene.ts
  • Run locally: npm install, then npm run dev
  • Checks: npm run typecheck and npm run build (there is no test suite yet)
  • Related docs: README.md

Filed by repo-audit/full-audit at b001f5d. Severity: medium. Effort: M. audit-key: testing|games/stack/logic.ts|tryRotate

主要语言
TypeScript
星标
3
派生
3
30 天内没有已合并 PR

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

TMHSDigital/GH-Arcade 的其他 Issue

查看 TMHSDigital/GH-Arcade 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。