Add unit tests for the Stack rules engine

Ouverte
  • Quelque chose ne va pas ?
#29 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
72/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
typescript
Domaine
game-dev, testing

Piste de recherche

Start with games/stack/logic.ts:104-208 and games/stack/scenes/GameScene.ts:423; the issue lists the rules and edge cases to cover in a new games/stack/logic.test.ts. Check the project's test setup because the issue says no test suite exists, then add tests for the listed behaviors and fix the gravitySeconds boundary defect. Done when the cases pass in CI.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

help wanted severity: medium testing

Summary

games/stack/logic.ts is Phaser-free and says in its header that it is easy to test, but has no tests. It is the most branch-heavy pure module in the repo, and it contains one boundary defect that a table test would catch.

Where

  • games/stack/logic.ts:104-208
  • games/stack/logic.ts:207 (gravitySeconds), games/stack/scenes/GameScene.ts:423 (level is uncapped)

Details

gravitySeconds raises a base that goes negative past level 115 to an integer power, so odd levels above 258 return large positive values: gravitySeconds(259) is about 4.68 where 1/60 is expected. It needs roughly 2,580 lines to reach, so it is a low-severity edge.

Suggested fix

Add games/stack/logic.test.ts:

  • emptyBoard() is 22 rows by 10 columns of null, rows are distinct arrays
  • spawn('I') is {rot:0,x:3,y:0}, spawn('O') has x=4; none collide on an empty board
  • Every ROTATIONS[t] has 4 states of 4 cells
  • collides is true for x<0, x>=10, y>=22 and occupied cells; false for cells at y<0
  • tryMove returns null when blocked and does not mutate its input
  • tryRotate on O returns the same object; T rotates both ways; a wall kick from x=-1 lands in bounds; returns null when all five kicks are blocked; I uses its own kick table
  • dropDistance is 20 for a fresh I, O or T and 0 for a resting piece
  • lock reports lock-out for a piece entirely in the hidden rows
  • fullRows and clearRows handle none, one and two rows and keep 22 rows
  • Bag with a seeded RNG yields a permutation of all seven types per run of 7; peek does not consume and works across a refill
  • gravitySeconds is non-increasing and never below 1/60 for levels 1 to 500 (fails today; clamp the base at 0 or cap the level)

Acceptance criteria

  • The cases above pass in CI

Getting started

  • Relevant files: games/stack/logic.ts, games/stack/scenes/GameScene.ts
  • Run locally: npm install, then npm run dev
  • Checks: npm run typecheck and npm run build (there is no test suite yet)
  • Related docs: README.md

Filed by repo-audit/full-audit at b001f5d. Severity: medium. Effort: M. audit-key: testing|games/stack/logic.ts|tryRotate

Langage dominant
TypeScript
Étoiles
3
Forks
3
Aucune PR mergée en 30 j

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TMHSDigital/GH-Arcade

Toutes les issues de TMHSDigital/GH-Arcade

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.