Add unit tests for the Stack rules engine

未關閉
  • 哪裡不對？
#29 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
1-2 天
新手友好度
72/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
typescript
領域
game-dev, testing

研究方向

Start with games/stack/logic.ts:104-208 and games/stack/scenes/GameScene.ts:423; the issue lists the rules and edge cases to cover in a new games/stack/logic.test.ts. Check the project's test setup because the issue says no test suite exists, then add tests for the listed behaviors and fix the gravitySeconds boundary defect. Done when the cases pass in CI.

由索引模型根據 Issue 內容生成。

描述

help wanted severity: medium testing

Summary

games/stack/logic.ts is Phaser-free and says in its header that it is easy to test, but has no tests. It is the most branch-heavy pure module in the repo, and it contains one boundary defect that a table test would catch.

Where

  • games/stack/logic.ts:104-208
  • games/stack/logic.ts:207 (gravitySeconds), games/stack/scenes/GameScene.ts:423 (level is uncapped)

Details

gravitySeconds raises a base that goes negative past level 115 to an integer power, so odd levels above 258 return large positive values: gravitySeconds(259) is about 4.68 where 1/60 is expected. It needs roughly 2,580 lines to reach, so it is a low-severity edge.

Suggested fix

Add games/stack/logic.test.ts:

  • emptyBoard() is 22 rows by 10 columns of null, rows are distinct arrays
  • spawn('I') is {rot:0,x:3,y:0}, spawn('O') has x=4; none collide on an empty board
  • Every ROTATIONS[t] has 4 states of 4 cells
  • collides is true for x<0, x>=10, y>=22 and occupied cells; false for cells at y<0
  • tryMove returns null when blocked and does not mutate its input
  • tryRotate on O returns the same object; T rotates both ways; a wall kick from x=-1 lands in bounds; returns null when all five kicks are blocked; I uses its own kick table
  • dropDistance is 20 for a fresh I, O or T and 0 for a resting piece
  • lock reports lock-out for a piece entirely in the hidden rows
  • fullRows and clearRows handle none, one and two rows and keep 22 rows
  • Bag with a seeded RNG yields a permutation of all seven types per run of 7; peek does not consume and works across a refill
  • gravitySeconds is non-increasing and never below 1/60 for levels 1 to 500 (fails today; clamp the base at 0 or cap the level)

Acceptance criteria

  • The cases above pass in CI

Getting started

  • Relevant files: games/stack/logic.ts, games/stack/scenes/GameScene.ts
  • Run locally: npm install, then npm run dev
  • Checks: npm run typecheck and npm run build (there is no test suite yet)
  • Related docs: README.md

Filed by repo-audit/full-audit at b001f5d. Severity: medium. Effort: M. audit-key: testing|games/stack/logic.ts|tryRotate

主要語言
TypeScript
星號
3
分支
3
30 天內沒有已合併 PR

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

TMHSDigital/GH-Arcade 的其他 Issue

查看 TMHSDigital/GH-Arcade 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。