Neon Maze: a catch on the tick the last dot is eaten clears the level without losing a life

未关闭 适合新手
#104 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
72/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript
领域
game-dev

调研方向

从 games/maze/scenes/GameScene.ts 开始,阅读 tick()(约第 419-427 行),其中 checkCatches() 在 clearLevel() 之前运行。然后阅读第 460-482 行附近的 die() 和 clearLevel(),了解阶段如何被覆盖;再阅读第 196 行附近的 update(),了解 afterDeath() 在哪里运行。完成的标准是:在吃掉最后一个点的那一帧被捕获,会扣除一条命,且不会推进关卡;运行 npm test,如果测试套件有对应的测试工具,就为这种情况添加一项检查。

由索引模型根据 Issue 内容生成。

描述

bug good first issue severity: low

Summary

In Neon Maze, if a chaser catches the runner on the same tick that the last dot is eaten, the level clears and the life is never lost.

Where

  • games/maze/scenes/GameScene.ts:419-427 (tick: checkCatches() then if (this.dots.size === 0) this.clearLevel())
  • games/maze/scenes/GameScene.ts:460-462, :480-482 (die() sets phase 'dying', clearLevel() overwrites it with 'clearing')
  • games/maze/scenes/GameScene.ts:196-204 (update only calls afterDeath(), which takes the life, from 'dying')

Details

tick() moves the runner (eating the dot), moves the chasers, then calls checkCatches(), which can call die(). It then goes on to clearLevel() with no phase check, so the 'dying' phase is replaced by 'clearing' and afterDeath() never runs.

Impact

Rare and in the player's favour: the death effects play over a level clear, no life is lost, and the run can be credited with a clear (and the maze.clear trophy) it should not have.

Steps to reproduce

  1. Leave one dot next to a chaser's path.
  2. Eat it just as an unscared chaser reaches the runner.
  3. The death burst plays, then the next level starts with the same lives.

Suggested fix

In tick(), return after checkCatches() if the phase is no longer 'play', or check this.phase === 'play' before calling clearLevel().

Acceptance criteria

  • A catch on the frame of the last dot costs a life and does not advance the level.

Getting started

  • Relevant files: games/maze/scenes/GameScene.ts
  • How to run tests: npm test

Filed by repo-audit/full-audit at de2b25b. Severity: low. Effort: S. audit-key: bug|games/maze/scenes/GameScene.ts|tick

主要语言
TypeScript
星标
3
派生
3
平均合并
8 小时 13 分钟
30 天内合并 PR
2

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TMHSDigital/GH-Arcade 的其他 Issue

查看 TMHSDigital/GH-Arcade 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。