Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

refactor(erd): extract ErdViewController and ErdCanvas from _ErdViewState

未关闭
  • 哪里不对？
#1,690 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
45/100
Issue 类型
重构
描述清晰度
描述清楚
活跃度
活跃
技术栈
dart, flutter
领域
desktop, developer-experience

调研方向

Start with erd_view.dart and the existing operations in core/erd, including erd_group_ops, erd_note_ops and erd_saved_layout; first map how _ErdViewState shares its state across handlers. Split the controller and canvas into separate small PRs, then verify erd_view.dart is about 900 lines or less and build is readable. Add unit tests for selection, focus, saved views, groups and notes, and run the existing widget tests under test/features/erd unchanged.

由索引模型根据 Issue 内容生成。

描述

enhancement

Follow-up to #1362, which took erd_view.dart from 2,895 to 1,705 lines (layout engine, router and geometry in core/erd, ErdTableCard, ErdRelationPainter, ErdExporter, note and group widgets, search / views / export menus). What is left is one class, _ErdViewState: about 1,580 lines, ~135 members, ~31 state fields, and a 305-line build.

What is still in _ErdViewState
  • Canvas: scale, pan, fit (_setScale, _zoomBy, _fit), tap and hover (_tapCanvas, _hoverCanvas), the InteractiveViewer in build.
  • Selection and focus: _selectTable, _clearSelection, _syncFocus, _cardFocusFor, search picking.
  • Saved views: _applyState, _showState, _switchView, _newView, _renameView, _deleteView, _scheduleSave, _saveNow, _current.
  • Groups and notes: create, edit, gather, drag, resize.
  • Card dragging and re-routing: _dragStart/_dragMove/_dragEnd, _scheduleRoutes.
Change
  1. ErdViewController (a ChangeNotifier, no widget imports) owns selection, focus, search state, saved views, groups and notes. The pure operations that already live in core/erd (erd_group_ops, erd_note_ops, erd_saved_layout) stay there and are called from it.
  2. ErdCanvas widget owns the InteractiveViewer, scale / fit / tap / hover and the drag of cards.
  3. _ErdViewState composes the two with the toolbar, menus and dialogs.
Acceptance
  • erd_view.dart is at most ~900 lines, and build is split into parts of a readable size.
  • Selection, focus, saved-view switching, groups and notes are covered by unit tests that need no WidgetTester.
  • The existing 52 widget tests under test/features/erd pass unchanged (no loosened expectations).
  • No change in behaviour or look; hover and drag rebuild only what they rebuilt before (#1169, #1168).
Not in scope
  • The minimap from #1362: there is no minimap in the product.
  • The "under 300 lines" target of #1362: it no longer describes how the view is built.
Notes

Medium risk (31 fields shared by most handlers); do it as a few small PRs: controller first, canvas second. Low priority unless ERD work is planned.

主要语言
Dart
星标
23
派生
1
平均合并
31 分钟
30 天内合并 PR
570

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

QueryaHub/Querya-Desktop 的其他 Issue

查看 QueryaHub/Querya-Desktop 的全部 Issue

相似的 Issue

更多 Dart Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。