Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

refactor(erd): extract ErdViewController and ErdCanvas from _ErdViewState

Ouverte
  • Quelque chose ne va pas ?
#1,690 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
5/5
Temps estimé
Plus d'une semaine
Accessibilité débutants
45/100
Type d'issue
Refactorisation
Clarté
Clairement spécifiée
Activité
Active
Stack technique
dart, flutter
Domaine
desktop, developer-experience

Piste de recherche

Start with erd_view.dart and the existing operations in core/erd, including erd_group_ops, erd_note_ops and erd_saved_layout; first map how _ErdViewState shares its state across handlers. Split the controller and canvas into separate small PRs, then verify erd_view.dart is about 900 lines or less and build is readable. Add unit tests for selection, focus, saved views, groups and notes, and run the existing widget tests under test/features/erd unchanged.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

enhancement

Follow-up to #1362, which took erd_view.dart from 2,895 to 1,705 lines (layout engine, router and geometry in core/erd, ErdTableCard, ErdRelationPainter, ErdExporter, note and group widgets, search / views / export menus). What is left is one class, _ErdViewState: about 1,580 lines, ~135 members, ~31 state fields, and a 305-line build.

What is still in _ErdViewState
  • Canvas: scale, pan, fit (_setScale, _zoomBy, _fit), tap and hover (_tapCanvas, _hoverCanvas), the InteractiveViewer in build.
  • Selection and focus: _selectTable, _clearSelection, _syncFocus, _cardFocusFor, search picking.
  • Saved views: _applyState, _showState, _switchView, _newView, _renameView, _deleteView, _scheduleSave, _saveNow, _current.
  • Groups and notes: create, edit, gather, drag, resize.
  • Card dragging and re-routing: _dragStart/_dragMove/_dragEnd, _scheduleRoutes.
Change
  1. ErdViewController (a ChangeNotifier, no widget imports) owns selection, focus, search state, saved views, groups and notes. The pure operations that already live in core/erd (erd_group_ops, erd_note_ops, erd_saved_layout) stay there and are called from it.
  2. ErdCanvas widget owns the InteractiveViewer, scale / fit / tap / hover and the drag of cards.
  3. _ErdViewState composes the two with the toolbar, menus and dialogs.
Acceptance
  • erd_view.dart is at most ~900 lines, and build is split into parts of a readable size.
  • Selection, focus, saved-view switching, groups and notes are covered by unit tests that need no WidgetTester.
  • The existing 52 widget tests under test/features/erd pass unchanged (no loosened expectations).
  • No change in behaviour or look; hover and drag rebuild only what they rebuilt before (#1169, #1168).
Not in scope
  • The minimap from #1362: there is no minimap in the product.
  • The "under 300 lines" target of #1362: it no longer describes how the view is built.
Notes

Medium risk (31 fields shared by most handlers); do it as a few small PRs: controller first, canvas second. Low priority unless ERD work is planned.

Langage dominant
Dart
Étoiles
23
Forks
1
Merge moyen
31 min
PR mergées (30 j)
570

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de QueryaHub/Querya-Desktop

Toutes les issues de QueryaHub/Querya-Desktop

Issues similaires

Plus d'issues Dart

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.