Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

refactor(erd): extract ErdViewController and ErdCanvas from _ErdViewState

Abierto
  • ¿Algo no está bien?
#1,690 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
45/100
Tipo de issue
Refactorización
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
dart, flutter
Área
desktop, developer-experience

Línea de trabajo

Start with erd_view.dart and the existing operations in core/erd, including erd_group_ops, erd_note_ops and erd_saved_layout; first map how _ErdViewState shares its state across handlers. Split the controller and canvas into separate small PRs, then verify erd_view.dart is about 900 lines or less and build is readable. Add unit tests for selection, focus, saved views, groups and notes, and run the existing widget tests under test/features/erd unchanged.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement

Follow-up to #1362, which took erd_view.dart from 2,895 to 1,705 lines (layout engine, router and geometry in core/erd, ErdTableCard, ErdRelationPainter, ErdExporter, note and group widgets, search / views / export menus). What is left is one class, _ErdViewState: about 1,580 lines, ~135 members, ~31 state fields, and a 305-line build.

What is still in _ErdViewState
  • Canvas: scale, pan, fit (_setScale, _zoomBy, _fit), tap and hover (_tapCanvas, _hoverCanvas), the InteractiveViewer in build.
  • Selection and focus: _selectTable, _clearSelection, _syncFocus, _cardFocusFor, search picking.
  • Saved views: _applyState, _showState, _switchView, _newView, _renameView, _deleteView, _scheduleSave, _saveNow, _current.
  • Groups and notes: create, edit, gather, drag, resize.
  • Card dragging and re-routing: _dragStart/_dragMove/_dragEnd, _scheduleRoutes.
Change
  1. ErdViewController (a ChangeNotifier, no widget imports) owns selection, focus, search state, saved views, groups and notes. The pure operations that already live in core/erd (erd_group_ops, erd_note_ops, erd_saved_layout) stay there and are called from it.
  2. ErdCanvas widget owns the InteractiveViewer, scale / fit / tap / hover and the drag of cards.
  3. _ErdViewState composes the two with the toolbar, menus and dialogs.
Acceptance
  • erd_view.dart is at most ~900 lines, and build is split into parts of a readable size.
  • Selection, focus, saved-view switching, groups and notes are covered by unit tests that need no WidgetTester.
  • The existing 52 widget tests under test/features/erd pass unchanged (no loosened expectations).
  • No change in behaviour or look; hover and drag rebuild only what they rebuilt before (#1169, #1168).
Not in scope
  • The minimap from #1362: there is no minimap in the product.
  • The "under 300 lines" target of #1362: it no longer describes how the view is built.
Notes

Medium risk (31 fields shared by most handlers); do it as a few small PRs: controller first, canvas second. Low priority unless ERD work is planned.

Lenguaje dominante
Dart
Estrellas
23
Forks
1
Merge medio
31 min
PR fusionados (30 d)
570

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de QueryaHub/Querya-Desktop

Todos los issues de QueryaHub/Querya-Desktop

Issues similares

Más issues de Dart

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.