Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

refactor(erd): extract ErdViewController and ErdCanvas from _ErdViewState

Aperta
  • Qualcosa non va?
#1,690 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
45/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
dart, flutter
Ambito
desktop, developer-experience

Direzione di ricerca

Start with erd_view.dart and the existing operations in core/erd, including erd_group_ops, erd_note_ops and erd_saved_layout; first map how _ErdViewState shares its state across handlers. Split the controller and canvas into separate small PRs, then verify erd_view.dart is about 900 lines or less and build is readable. Add unit tests for selection, focus, saved views, groups and notes, and run the existing widget tests under test/features/erd unchanged.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

Follow-up to #1362, which took erd_view.dart from 2,895 to 1,705 lines (layout engine, router and geometry in core/erd, ErdTableCard, ErdRelationPainter, ErdExporter, note and group widgets, search / views / export menus). What is left is one class, _ErdViewState: about 1,580 lines, ~135 members, ~31 state fields, and a 305-line build.

What is still in _ErdViewState
  • Canvas: scale, pan, fit (_setScale, _zoomBy, _fit), tap and hover (_tapCanvas, _hoverCanvas), the InteractiveViewer in build.
  • Selection and focus: _selectTable, _clearSelection, _syncFocus, _cardFocusFor, search picking.
  • Saved views: _applyState, _showState, _switchView, _newView, _renameView, _deleteView, _scheduleSave, _saveNow, _current.
  • Groups and notes: create, edit, gather, drag, resize.
  • Card dragging and re-routing: _dragStart/_dragMove/_dragEnd, _scheduleRoutes.
Change
  1. ErdViewController (a ChangeNotifier, no widget imports) owns selection, focus, search state, saved views, groups and notes. The pure operations that already live in core/erd (erd_group_ops, erd_note_ops, erd_saved_layout) stay there and are called from it.
  2. ErdCanvas widget owns the InteractiveViewer, scale / fit / tap / hover and the drag of cards.
  3. _ErdViewState composes the two with the toolbar, menus and dialogs.
Acceptance
  • erd_view.dart is at most ~900 lines, and build is split into parts of a readable size.
  • Selection, focus, saved-view switching, groups and notes are covered by unit tests that need no WidgetTester.
  • The existing 52 widget tests under test/features/erd pass unchanged (no loosened expectations).
  • No change in behaviour or look; hover and drag rebuild only what they rebuilt before (#1169, #1168).
Not in scope
  • The minimap from #1362: there is no minimap in the product.
  • The "under 300 lines" target of #1362: it no longer describes how the view is built.
Notes

Medium risk (31 fields shared by most handlers); do it as a few small PRs: controller first, canvas second. Low priority unless ERD work is planned.

Lingua principale
Dart
Stelle
23
Fork
1
Merge medio
31m
PR unite (30g)
570

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di QueryaHub/Querya-Desktop

Tutte le issue di QueryaHub/Querya-Desktop

Issue simili

Altre issue su Dart

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.