drift-check: let the refresh PR's runs start without a maintainer's approval

未关闭
#74 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
55/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
github, github-actions, python
领域
ci-cd

调研方向

Read .github/workflows/drift-check.yml, especially the PERMISSIONS comment and the steps that push to drift/refresh and create the PR. Check how the repository supplies secrets to workflows and verify the chosen token has the needed contents and pull requests access. Done means refresh PR runs start without maintainer approval while the approval policy for outside contributors stays unchanged.

由索引模型根据 Issue 内容生成。

描述

What happens

The nightly drift-check opens or updates the drift/refresh PR with the workflow's built-in GITHUB_TOKEN, so the PR's author is github-actions[bot]. The repository's Actions policy, "Require approval for all external contributors", counts the bot as an external contributor. So every run on the refresh PR (drift-check, pool-check and site-build) waits as action_required until a maintainer approves it. For example, the runs on #69 at 6b87e20 waited from 03:50 UTC on 2026-11-19 until they were approved by hand.

Options

  1. Open the PR with another token (recommended). Use a QuantEcon GitHub App's installation token (from actions/create-github-app-token) or a maintainer's fine-grained token for the push to drift/refresh and for gh pr create. The PR's runs would then start as a maintainer's do. The approval policy would stay as it is for outside contributors, and the review would stay at the merge.
    • It needs an App (or a token) with write access to contents and pull requests on this repository, its ID and private key as repository secrets, and a change to .github/workflows/drift-check.yml.
    • A maintainer's token is known to avoid the hold. An App's token very likely does too; the first refresh after the change would confirm it.
  2. Relax the policy in Settings → Actions → General → "Approval for running fork pull request workflows from contributors". This loosens it for every contributor to a public repository whose PR runs can use paid RunsOn machines. It may also not free the bot, which can still count as a first-time contributor.

The PERMISSIONS comment in drift-check.yml describes the current behaviour, so it should change along with it.

Until then

Approve the refresh PR's runs when you review it, as now. Nothing is urgent.

主要语言
Python
星标
1
派生
0
平均合并
2 小时 51 分钟
30 天内合并 PR
41

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

QuantEcon/lectures 的其他 Issue

查看 QuantEcon/lectures 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。