drift-check: let the refresh PR's runs start without a maintainer's approval

オープン
#74 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
55/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
github, github-actions, python
領域
ci-cd

調査の方向性

Read .github/workflows/drift-check.yml, especially the PERMISSIONS comment and the steps that push to drift/refresh and create the PR. Check how the repository supplies secrets to workflows and verify the chosen token has the needed contents and pull requests access. Done means refresh PR runs start without maintainer approval while the approval policy for outside contributors stays unchanged.

索引モデルが issue の本文から書いたものです。

説明

What happens

The nightly drift-check opens or updates the drift/refresh PR with the workflow's built-in GITHUB_TOKEN, so the PR's author is github-actions[bot]. The repository's Actions policy, "Require approval for all external contributors", counts the bot as an external contributor. So every run on the refresh PR (drift-check, pool-check and site-build) waits as action_required until a maintainer approves it. For example, the runs on #69 at 6b87e20 waited from 03:50 UTC on 2026-11-19 until they were approved by hand.

Options

  1. Open the PR with another token (recommended). Use a QuantEcon GitHub App's installation token (from actions/create-github-app-token) or a maintainer's fine-grained token for the push to drift/refresh and for gh pr create. The PR's runs would then start as a maintainer's do. The approval policy would stay as it is for outside contributors, and the review would stay at the merge.
    • It needs an App (or a token) with write access to contents and pull requests on this repository, its ID and private key as repository secrets, and a change to .github/workflows/drift-check.yml.
    • A maintainer's token is known to avoid the hold. An App's token very likely does too; the first refresh after the change would confirm it.
  2. Relax the policy in Settings → Actions → General → "Approval for running fork pull request workflows from contributors". This loosens it for every contributor to a public repository whose PR runs can use paid RunsOn machines. It may also not free the bot, which can still count as a first-time contributor.

The PERMISSIONS comment in drift-check.yml describes the current behaviour, so it should change along with it.

Until then

Approve the refresh PR's runs when you review it, as now. Nothing is urgent.

主要言語
Python
スター
1
フォーク
0
平均マージ
2時間 51分
マージ済み PR(30日)
41

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

QuantEcon/lectures のほかの issue

QuantEcon/lectures の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。