drift-check: let the refresh PR's runs start without a maintainer's approval

Aperta
#74 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
github, github-actions, python
Ambito
ci-cd

Direzione di ricerca

Read .github/workflows/drift-check.yml, especially the PERMISSIONS comment and the steps that push to drift/refresh and create the PR. Check how the repository supplies secrets to workflows and verify the chosen token has the needed contents and pull requests access. Done means refresh PR runs start without maintainer approval while the approval policy for outside contributors stays unchanged.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

What happens

The nightly drift-check opens or updates the drift/refresh PR with the workflow's built-in GITHUB_TOKEN, so the PR's author is github-actions[bot]. The repository's Actions policy, "Require approval for all external contributors", counts the bot as an external contributor. So every run on the refresh PR (drift-check, pool-check and site-build) waits as action_required until a maintainer approves it. For example, the runs on #69 at 6b87e20 waited from 03:50 UTC on 2026-11-19 until they were approved by hand.

Options

  1. Open the PR with another token (recommended). Use a QuantEcon GitHub App's installation token (from actions/create-github-app-token) or a maintainer's fine-grained token for the push to drift/refresh and for gh pr create. The PR's runs would then start as a maintainer's do. The approval policy would stay as it is for outside contributors, and the review would stay at the merge.
    • It needs an App (or a token) with write access to contents and pull requests on this repository, its ID and private key as repository secrets, and a change to .github/workflows/drift-check.yml.
    • A maintainer's token is known to avoid the hold. An App's token very likely does too; the first refresh after the change would confirm it.
  2. Relax the policy in Settings → Actions → General → "Approval for running fork pull request workflows from contributors". This loosens it for every contributor to a public repository whose PR runs can use paid RunsOn machines. It may also not free the bot, which can still count as a first-time contributor.

The PERMISSIONS comment in drift-check.yml describes the current behaviour, so it should change along with it.

Until then

Approve the refresh PR's runs when you review it, as now. Nothing is urgent.

Lingua principale
Python
Stelle
1
Fork
0
Merge medio
2h 51m
PR unite (30g)
41

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di QuantEcon/lectures

Tutte le issue di QuantEcon/lectures

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.