drift-check: let the refresh PR's runs start without a maintainer's approval
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 55/100
Línea de trabajo
Read .github/workflows/drift-check.yml, especially the PERMISSIONS comment and the steps that push to drift/refresh and create the PR. Check how the repository supplies secrets to workflows and verify the chosen token has the needed contents and pull requests access. Done means refresh PR runs start without maintainer approval while the approval policy for outside contributors stays unchanged.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
What happens
The nightly drift-check opens or updates the drift/refresh PR with the workflow's built-in GITHUB_TOKEN, so the PR's author is github-actions[bot]. The repository's Actions policy, "Require approval for all external contributors", counts the bot as an external contributor. So every run on the refresh PR (drift-check, pool-check and site-build) waits as action_required until a maintainer approves it. For example, the runs on #69 at 6b87e20 waited from 03:50 UTC on 2026-11-19 until they were approved by hand.
Options
- Open the PR with another token (recommended). Use a QuantEcon GitHub App's installation token (from
actions/create-github-app-token) or a maintainer's fine-grained token for the push todrift/refreshand forgh pr create. The PR's runs would then start as a maintainer's do. The approval policy would stay as it is for outside contributors, and the review would stay at the merge.- It needs an App (or a token) with write access to contents and pull requests on this repository, its ID and private key as repository secrets, and a change to
.github/workflows/drift-check.yml. - A maintainer's token is known to avoid the hold. An App's token very likely does too; the first refresh after the change would confirm it.
- It needs an App (or a token) with write access to contents and pull requests on this repository, its ID and private key as repository secrets, and a change to
- Relax the policy in Settings → Actions → General → "Approval for running fork pull request workflows from contributors". This loosens it for every contributor to a public repository whose PR runs can use paid RunsOn machines. It may also not free the bot, which can still count as a first-time contributor.
The PERMISSIONS comment in drift-check.yml describes the current behaviour, so it should change along with it.
Until then
Approve the refresh PR's runs when you review it, as now. Nothing is urgent.
- Lenguaje dominante
- Python
- Estrellas
- 1
- Forks
- 0
- Merge medio
- 2 h 51 min
- PR fusionados (30 d)
- 41
Preparar el entorno
Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de QuantEcon/lectures
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día
-
question
Dificultad 4/5 1-2 días Aptitud para principiantes 44/100
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 4/5 3-5 días Aptitud para principiantes 54/100
QuantEcon/lectures#24 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 4/5 3-5 días Aptitud para principiantes 52/100
QuantEcon/lectures#22 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 4/5 3-5 días Aptitud para principiantes 47/100
Los mantenedores suelen responder en 1 día
Todos los issues de QuantEcon/lectures
Issues similares
-
needs-triage
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
flashinfer-ai/flashinfer#9803 ·
Los mantenedores suelen responder en 1 día
-
bug frontend good first issue help wanted
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
oscarbol09/thesisforge#61 ·
-
api bug performance
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
oscarbol09/audiobard#159 ·
-
area:web p2 product:business triage:active type:bug
Dificultad 1/5 Menos de una hora Aptitud para principiantes 89/100
cuadrao-ai/argus#2328 ·
Los mantenedores suelen responder en 1 día
-
bug frontend good first issue help wanted
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
nikhilb2/simple_invoicing#907 ·