Follow-ups left open by the 8852C ACK responder review (#489)

未关闭
#490 5 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
6/100
Issue 类型
缺陷
描述清晰度
需要澄清
活跃度
活跃
技术栈
c

调研方向

Start with the #489 review thread, since most measurements are excluded there. Item 3 is the most contained entry point: HalKestrel::coex_mac_init sets ENBT only for the 8852B, so the 8852C path needs a fix. Item 1 depends on hardware bench work with a firmware RAM dump and a vendor A/B, and AdapterCaps.h holds the matrix to update. Done means a root cause or a reproducible fix for the dead-ACK sessions, not a guess.

由索引模型根据 Issue 内容生成。

描述

enhancement

Left open by the review and bisect of #489 (8852C hardware ACK responder). Bench: TX50UH (RTL8832CU) x2, 8812CU soliciting with CCX tx.report, near field.

1. 8852C bring-ups that never answer an ACK: cause unknown

The responder arms, the entry reads back, injection works, and the chip answers no ACK for the whole session. Measured rate on this bench: ~1/3 of soft re-runs in the morning, ~85% by the afternoon, on ch161 and ch6, on both units; one 8852B-side report of ~1 in 55 from the author.

Excluded by measurement (details in the #489 review thread):

  • temperature (meter flat; dead at the coldest reading after 120 s VBUS-offs) and retained chip state (120 s VBUS cuts);
  • the TX chain (99% of host-injected frames witnessed in a dead session) and the soliciting side (an independent witness sees the ACKs vanish);
  • every host-readable register and SRAM read at the correct 0x20 stride: ADDR_CAM, BSSID CAM, DMAC/CMAC tables (uninitialised in RX-only sessions, no separating bit), MAC 0x8000/0xC000/0xD800 blocks, BB 0x10000-0x17FFF, RF path 0/1, GNT;
  • levers: host-written minimal and vendor-default CMAC entries, the CMAC H2C, forced WiFi-only GNT with and without the vendor coex init, a host-written BSSID CAM entry, the CAM slot.

The one lead: R_AX_WMAC_TX_INFO0_DEBUG (0xCAE8) reads 0x10914012 in every dead session and 0x10915012 in good ones (bit 12), so the TMAC does issue the response, and the RF path-0 TX registers show it never reaches the RF. Next experiments: a firmware RAM dump dead vs good, and a vendor rtl8852cu A/B on the same unit with a real station answering, to learn whether the vendor bring-up ever shows the state at all.

2. Kestrel host injection on ch161 nearly silent

Both TX50UH units, txdemo TX-only at 6M, 20 ms gap, ch161: 6-10 of ~290 frames witnessed, by either an 8852C or the 8812CU, in good and dead ACK sessions alike. Same setup on ch6: 97-99%. Earlier 8852C -> 8812CU injection A/Bs (~97%) were on ch6. Needs a 5 GHz injection A/B against the vendor driver on this unit before any 5 GHz Kestrel TX number is trusted.

3. 8852C coex init on the C die is a no-op

HalKestrel::coex_mac_init sets ENBT for the 8852B only, so on the 8852C both write_lte calls time out ("Kestrel coex: LTE interface not ready" twice per session) and the GNT stance is skipped. The vendor's 8852C path (coex_8852c.c) does not use the LTE window (mac_write_lte_8852c returns MACNOTSUP); it writes R_AX_GNT_SW_CTRL and R_AX_BTC_CFG / R_AX_BT_CNT_CFG / R_AX_CCA_CFG_0 directly. Cold state read on this unit: GNT_SW_CTRL 0x175775, GNT_VAL 0x118 (BT granted, WL not), BTC_CFG bit 31 clear. Forcing the WiFi-only grant did not change item 1, so this is a correctness cleanup, not a fix.

4. Bench note

The dead rate in item 1 rose through a day of back-to-back sessions on both units and no power cycle reset it. Anyone measuring the 8852C responder late in a session day will see a different rate from the morning; the matrix in AdapterCaps.h should say when in the day its rows were taken.

主要语言
C
星标
56
派生
29
平均合并
3 小时 43 分钟
30 天内合并 PR
75

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

OpenIPC/devourer 的其他 Issue

查看 OpenIPC/devourer 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。