Follow-ups left open by the 8852C ACK responder review (#489)

Abierto
#490 5 comentarios 1 reacción 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
6/100
Tipo de issue
Error
Claridad
Necesita aclaración
Estado de actividad
Activo
Stack tecnológico
c

Línea de trabajo

Start with the #489 review thread, since most measurements are excluded there. Item 3 is the most contained entry point: HalKestrel::coex_mac_init sets ENBT only for the 8852B, so the 8852C path needs a fix. Item 1 depends on hardware bench work with a firmware RAM dump and a vendor A/B, and AdapterCaps.h holds the matrix to update. Done means a root cause or a reproducible fix for the dead-ACK sessions, not a guess.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement

Left open by the review and bisect of #489 (8852C hardware ACK responder). Bench: TX50UH (RTL8832CU) x2, 8812CU soliciting with CCX tx.report, near field.

1. 8852C bring-ups that never answer an ACK: cause unknown

The responder arms, the entry reads back, injection works, and the chip answers no ACK for the whole session. Measured rate on this bench: ~1/3 of soft re-runs in the morning, ~85% by the afternoon, on ch161 and ch6, on both units; one 8852B-side report of ~1 in 55 from the author.

Excluded by measurement (details in the #489 review thread):

  • temperature (meter flat; dead at the coldest reading after 120 s VBUS-offs) and retained chip state (120 s VBUS cuts);
  • the TX chain (99% of host-injected frames witnessed in a dead session) and the soliciting side (an independent witness sees the ACKs vanish);
  • every host-readable register and SRAM read at the correct 0x20 stride: ADDR_CAM, BSSID CAM, DMAC/CMAC tables (uninitialised in RX-only sessions, no separating bit), MAC 0x8000/0xC000/0xD800 blocks, BB 0x10000-0x17FFF, RF path 0/1, GNT;
  • levers: host-written minimal and vendor-default CMAC entries, the CMAC H2C, forced WiFi-only GNT with and without the vendor coex init, a host-written BSSID CAM entry, the CAM slot.

The one lead: R_AX_WMAC_TX_INFO0_DEBUG (0xCAE8) reads 0x10914012 in every dead session and 0x10915012 in good ones (bit 12), so the TMAC does issue the response, and the RF path-0 TX registers show it never reaches the RF. Next experiments: a firmware RAM dump dead vs good, and a vendor rtl8852cu A/B on the same unit with a real station answering, to learn whether the vendor bring-up ever shows the state at all.

2. Kestrel host injection on ch161 nearly silent

Both TX50UH units, txdemo TX-only at 6M, 20 ms gap, ch161: 6-10 of ~290 frames witnessed, by either an 8852C or the 8812CU, in good and dead ACK sessions alike. Same setup on ch6: 97-99%. Earlier 8852C -> 8812CU injection A/Bs (~97%) were on ch6. Needs a 5 GHz injection A/B against the vendor driver on this unit before any 5 GHz Kestrel TX number is trusted.

3. 8852C coex init on the C die is a no-op

HalKestrel::coex_mac_init sets ENBT for the 8852B only, so on the 8852C both write_lte calls time out ("Kestrel coex: LTE interface not ready" twice per session) and the GNT stance is skipped. The vendor's 8852C path (coex_8852c.c) does not use the LTE window (mac_write_lte_8852c returns MACNOTSUP); it writes R_AX_GNT_SW_CTRL and R_AX_BTC_CFG / R_AX_BT_CNT_CFG / R_AX_CCA_CFG_0 directly. Cold state read on this unit: GNT_SW_CTRL 0x175775, GNT_VAL 0x118 (BT granted, WL not), BTC_CFG bit 31 clear. Forcing the WiFi-only grant did not change item 1, so this is a correctness cleanup, not a fix.

4. Bench note

The dead rate in item 1 rose through a day of back-to-back sessions on both units and no power cycle reset it. Anyone measuring the 8852C responder late in a session day will see a different rate from the morning; the matrix in AdapterCaps.h should say when in the day its rows were taken.

Lenguaje dominante
C
Estrellas
56
Forks
29
Merge medio
3 h 43 min
PR fusionados (30 d)
75

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de OpenIPC/devourer

Todos los issues de OpenIPC/devourer

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.