Logo is invisible on GitHub's light theme

未关闭
#440 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
半天
新手友好度
25/100
Issue 类型
缺陷
描述清晰度
需要澄清
活跃度
活跃
领域
design

调研方向

The payload names no file, component or theme setting; it links only to the NanoForge-dev organisation and a screenshot of the logo in white mode. Start by finding the theme toggle and the logo asset the screenshot shows, then check how the logo is styled under the light theme. Done means the logo stays readable in white mode, which you can confirm by switching themes and comparing against the screenshot. Ask in the issue which logo file is meant before you change anything.

由索引模型根据 Issue 内容生成。

描述

documentation
What is the type of issue?

Something else

What is the issue?

The NanoForge logo does not show well on GitHub's light theme: it is drawn for a dark background, and there is only one version of it.

  • The org profile (NanoForge-dev/.github profile/README.md) embeds profile/logo.png with a plain <img>.
  • Every Engine README embeds .github/logo.png the same way, through a blob/ URL, e.g. the root README and modules/ecs (16 READMEs in total).
  • No README in the org has a light/dark variant (no <picture> or prefers-color-scheme). The other repos (CLI, Loader, Editor, actions, API, components-systems, examples, landing, the web apps) use the same single logo.

Screenshot of the org profile in light mode:

Org profile in light mode: the logo is hard to see

Expected:

  • A light-theme and a dark-theme logo file.
  • Each README shows the logo with <picture> and <source media="(prefers-color-scheme: dark)"> / (prefers-color-scheme: light), using raw image URLs (https://raw.githubusercontent.com/...), not blob/ URLs.
  • Done in the org profile README and in every Engine README that embeds logo.png.

#466 changes the same <img> lines (the blob/ URL does not render outside GitHub): fix both in one PR.

Open questions (not recorded, ask the team):

  • The org profile lives in NanoForge-dev/.github: transfer this issue there and keep #466 for the Engine READMEs, or keep it here?
  • Who provides the light-theme logo file?
  • Fix the other repos' READMEs in the same pass (one issue per repo), or not?
Where did you find it?

https://github.com/NanoForge-dev (org profile, light theme), and every Engine README, e.g. https://github.com/NanoForge-dev/Engine/blob/35f5644b821d6dedf3cdb3c4d2d5d4ab84f54f21/README.md#L4

主要语言
TypeScript
星标
7
派生
2
平均合并
1 天 17 小时
30 天内合并 PR
17

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

NanoForge-dev/Engine 的其他 Issue

查看 NanoForge-dev/Engine 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。