Logo is invisible on GitHub's light theme

Abierto
  • ¿Algo no está bien?
#440 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
Medio día
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Necesita aclaración
Estado de actividad
Activo
Área
design

Línea de trabajo

The payload names no file, component or theme setting; it links only to the NanoForge-dev organisation and a screenshot of the logo in white mode. Start by finding the theme toggle and the logo asset the screenshot shows, then check how the logo is styled under the light theme. Done means the logo stays readable in white mode, which you can confirm by switching themes and comparing against the screenshot. Ask in the issue which logo file is meant before you change anything.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

documentation
What is the type of issue?

Something else

What is the issue?

The NanoForge logo does not show well on GitHub's light theme: it is drawn for a dark background, and there is only one version of it.

  • The org profile (NanoForge-dev/.github profile/README.md) embeds profile/logo.png with a plain <img>.
  • Every Engine README embeds .github/logo.png the same way, through a blob/ URL, e.g. the root README and modules/ecs (16 READMEs in total).
  • No README in the org has a light/dark variant (no <picture> or prefers-color-scheme). The other repos (CLI, Loader, Editor, actions, API, components-systems, examples, landing, the web apps) use the same single logo.

Screenshot of the org profile in light mode:

Org profile in light mode: the logo is hard to see

Expected:

  • A light-theme and a dark-theme logo file.
  • Each README shows the logo with <picture> and <source media="(prefers-color-scheme: dark)"> / (prefers-color-scheme: light), using raw image URLs (https://raw.githubusercontent.com/...), not blob/ URLs.
  • Done in the org profile README and in every Engine README that embeds logo.png.

#466 changes the same <img> lines (the blob/ URL does not render outside GitHub): fix both in one PR.

Open questions (not recorded, ask the team):

  • The org profile lives in NanoForge-dev/.github: transfer this issue there and keep #466 for the Engine READMEs, or keep it here?
  • Who provides the light-theme logo file?
  • Fix the other repos' READMEs in the same pass (one issue per repo), or not?
Where did you find it?

https://github.com/NanoForge-dev (org profile, light theme), and every Engine README, e.g. https://github.com/NanoForge-dev/Engine/blob/35f5644b821d6dedf3cdb3c4d2d5d4ab84f54f21/README.md#L4

Lenguaje dominante
TypeScript
Estrellas
7
Forks
2
Merge medio
1 d 17 h
PR fusionados (30 d)
17

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de NanoForge-dev/Engine

Todos los issues de NanoForge-dev/Engine

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.