Logo is invisible on GitHub's light theme

Aberta
  • Algo errado?
#440 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
Meio dia
Facilidade para iniciantes
25/100
Tipo de issue
Bug
Clareza
Precisa de esclarecimento
Status de atividade
Ativa
Domínio
design

Direção de pesquisa

The payload names no file, component or theme setting; it links only to the NanoForge-dev organisation and a screenshot of the logo in white mode. Start by finding the theme toggle and the logo asset the screenshot shows, then check how the logo is styled under the light theme. Done means the logo stays readable in white mode, which you can confirm by switching themes and comparing against the screenshot. Ask in the issue which logo file is meant before you change anything.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

documentation
What is the type of issue?

Something else

What is the issue?

The NanoForge logo does not show well on GitHub's light theme: it is drawn for a dark background, and there is only one version of it.

  • The org profile (NanoForge-dev/.github profile/README.md) embeds profile/logo.png with a plain <img>.
  • Every Engine README embeds .github/logo.png the same way, through a blob/ URL, e.g. the root README and modules/ecs (16 READMEs in total).
  • No README in the org has a light/dark variant (no <picture> or prefers-color-scheme). The other repos (CLI, Loader, Editor, actions, API, components-systems, examples, landing, the web apps) use the same single logo.

Screenshot of the org profile in light mode:

Org profile in light mode: the logo is hard to see

Expected:

  • A light-theme and a dark-theme logo file.
  • Each README shows the logo with <picture> and <source media="(prefers-color-scheme: dark)"> / (prefers-color-scheme: light), using raw image URLs (https://raw.githubusercontent.com/...), not blob/ URLs.
  • Done in the org profile README and in every Engine README that embeds logo.png.

#466 changes the same <img> lines (the blob/ URL does not render outside GitHub): fix both in one PR.

Open questions (not recorded, ask the team):

  • The org profile lives in NanoForge-dev/.github: transfer this issue there and keep #466 for the Engine READMEs, or keep it here?
  • Who provides the light-theme logo file?
  • Fix the other repos' READMEs in the same pass (one issue per repo), or not?
Where did you find it?

https://github.com/NanoForge-dev (org profile, light theme), and every Engine README, e.g. https://github.com/NanoForge-dev/Engine/blob/35f5644b821d6dedf3cdb3c4d2d5d4ab84f54f21/README.md#L4

Linguagem predominante
TypeScript
Estrelas
7
Forks
2
Merge médio
1d 17h
PRs com merge (30d)
17

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de NanoForge-dev/Engine

Todas as issues de NanoForge-dev/Engine

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.