Logo is invisible on GitHub's light theme

Aperta
  • Qualcosa non va?
#440 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Da chiarire
Stato di attività
Attiva
Ambito
design

Direzione di ricerca

The payload names no file, component or theme setting; it links only to the NanoForge-dev organisation and a screenshot of the logo in white mode. Start by finding the theme toggle and the logo asset the screenshot shows, then check how the logo is styled under the light theme. Done means the logo stays readable in white mode, which you can confirm by switching themes and comparing against the screenshot. Ask in the issue which logo file is meant before you change anything.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

documentation
What is the type of issue?

Something else

What is the issue?

The NanoForge logo does not show well on GitHub's light theme: it is drawn for a dark background, and there is only one version of it.

  • The org profile (NanoForge-dev/.github profile/README.md) embeds profile/logo.png with a plain <img>.
  • Every Engine README embeds .github/logo.png the same way, through a blob/ URL, e.g. the root README and modules/ecs (16 READMEs in total).
  • No README in the org has a light/dark variant (no <picture> or prefers-color-scheme). The other repos (CLI, Loader, Editor, actions, API, components-systems, examples, landing, the web apps) use the same single logo.

Screenshot of the org profile in light mode:

Org profile in light mode: the logo is hard to see

Expected:

  • A light-theme and a dark-theme logo file.
  • Each README shows the logo with <picture> and <source media="(prefers-color-scheme: dark)"> / (prefers-color-scheme: light), using raw image URLs (https://raw.githubusercontent.com/...), not blob/ URLs.
  • Done in the org profile README and in every Engine README that embeds logo.png.

#466 changes the same <img> lines (the blob/ URL does not render outside GitHub): fix both in one PR.

Open questions (not recorded, ask the team):

  • The org profile lives in NanoForge-dev/.github: transfer this issue there and keep #466 for the Engine READMEs, or keep it here?
  • Who provides the light-theme logo file?
  • Fix the other repos' READMEs in the same pass (one issue per repo), or not?
Where did you find it?

https://github.com/NanoForge-dev (org profile, light theme), and every Engine README, e.g. https://github.com/NanoForge-dev/Engine/blob/35f5644b821d6dedf3cdb3c4d2d5d4ab84f54f21/README.md#L4

Lingua principale
TypeScript
Stelle
7
Fork
2
Merge medio
1g 17h
PR unite (30g)
17

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di NanoForge-dev/Engine

Tutte le issue di NanoForge-dev/Engine

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.