Fix plotting in owsa_opt_strat()

未关闭
  • 哪里不对？
#67 1 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 1 天内回复

@gknowlt 已经在做这个了。

开始于 2019年5月21日。

  • #236 来自 @feralaes —— 未关闭

评估

这个 Issue 还没有评估数据。

描述

bug

Fix plotting inconsistencies / quirks in owsa_opt_strat():

  • The ordering in which parameters are plotted isn't consistent. I think it should follow the same ordering as how the user inputs the strategies into the owsa object, regardless of alphabetical ordering or anything like that. The user likely has a desired ordering / grouping of parameters and we should follow their input! I think the function currently re-orders parameters in alphabetical ordering. Not sure if the ordering is changed in the creation of the owsa() function or just for plotting.

  • The boxes don't line up with axis labels. Also number of x-axis ticks isn't consistent and doesn't strictly follow the input parameter. Why is this happening?

  • Standardize x-axis labeling. I don't know exactly how to fix this, but sometimes the axis labels looked squished, whereas it would be nice if the axis labeling looked consistently clean across all parameters. Might require a bunch of use cases to see what's happening.

  • Changing the text size parameter doesn't change the size of the titles (param1, param2, etc.) at the top of each bar. We definitely want that to increase (perhaps as a separate parameter, since you may want larger titles while keeping the axis text smaller?)

主要语言
R
星标
43
派生
14
平均合并
4 小时 44 分钟
30 天内合并 PR
15

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

DARTH-git/dampack 的其他 Issue

查看 DARTH-git/dampack 的全部 Issue

相似的 Issue

更多 R Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。