Fix plotting in owsa_opt_strat()

Abierto
  • ¿Algo no está bien?
#67 1 comentario 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@gknowlt ya está trabajando en esto.

Desde el 21/5/2019.

  • #236 de @feralaes — abierto

Evaluación

Este issue todavía no se ha evaluado.

Descripción

bug

Fix plotting inconsistencies / quirks in owsa_opt_strat():

  • The ordering in which parameters are plotted isn't consistent. I think it should follow the same ordering as how the user inputs the strategies into the owsa object, regardless of alphabetical ordering or anything like that. The user likely has a desired ordering / grouping of parameters and we should follow their input! I think the function currently re-orders parameters in alphabetical ordering. Not sure if the ordering is changed in the creation of the owsa() function or just for plotting.

  • The boxes don't line up with axis labels. Also number of x-axis ticks isn't consistent and doesn't strictly follow the input parameter. Why is this happening?

  • Standardize x-axis labeling. I don't know exactly how to fix this, but sometimes the axis labels looked squished, whereas it would be nice if the axis labeling looked consistently clean across all parameters. Might require a bunch of use cases to see what's happening.

  • Changing the text size parameter doesn't change the size of the titles (param1, param2, etc.) at the top of each bar. We definitely want that to increase (perhaps as a separate parameter, since you may want larger titles while keeping the axis text smaller?)

Lenguaje dominante
R
Estrellas
43
Forks
14
Merge medio
4 h 44 min
PR fusionados (30 d)
15

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de DARTH-git/dampack

Todos los issues de DARTH-git/dampack

Issues similares

Más issues de R

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.