Fix plotting in owsa_opt_strat()

Aperta
  • Qualcosa non va?
#67 1 commento 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@gknowlt ci sta già lavorando.

Dal 21/5/2019.

  • #236 di @feralaes — aperta

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

bug

Fix plotting inconsistencies / quirks in owsa_opt_strat():

  • The ordering in which parameters are plotted isn't consistent. I think it should follow the same ordering as how the user inputs the strategies into the owsa object, regardless of alphabetical ordering or anything like that. The user likely has a desired ordering / grouping of parameters and we should follow their input! I think the function currently re-orders parameters in alphabetical ordering. Not sure if the ordering is changed in the creation of the owsa() function or just for plotting.

  • The boxes don't line up with axis labels. Also number of x-axis ticks isn't consistent and doesn't strictly follow the input parameter. Why is this happening?

  • Standardize x-axis labeling. I don't know exactly how to fix this, but sometimes the axis labels looked squished, whereas it would be nice if the axis labeling looked consistently clean across all parameters. Might require a bunch of use cases to see what's happening.

  • Changing the text size parameter doesn't change the size of the titles (param1, param2, etc.) at the top of each bar. We definitely want that to increase (perhaps as a separate parameter, since you may want larger titles while keeping the axis text smaller?)

Lingua principale
R
Stelle
43
Fork
14
Merge medio
4h 44m
PR unite (30g)
15

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di DARTH-git/dampack

Tutte le issue di DARTH-git/dampack

Issue simili

Altre issue su R

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.