Enable branch protection — 13 workflows, none of them required

未关闭
#724 0 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 1 天内回复

@christian-byrne 已经在做这个了。

开始于 2026年8月23日。

评估

这个 Issue 还没有评估数据。

描述

audit:github effort:trivial priority:critical

What — main has no branch protection rule, so none of the repo's 13 workflows is a required status check.

Why it matters here — This is a public package with 45 contributors and 30 published releases. pytest, ruff, build-and-test, and the mac/windows/GPU matrices all run on every PR and every one of them is advisory — a PR with a red test suite can be merged and published. The checks are already written and already run; they just do not block. Of the six repos swept this is the one where the gap costs the most, because releases go to PyPI.

Evidence

$ gh api repos/Comfy-Org/comfy-cli/branches/main/protection
gh: Branch not protected (HTTP 404)

$ ls .github/workflows/ | wc -l
13

$ gh api repos/Comfy-Org/comfy-cli -q '"contributors_visible releases=\(.  )"' ; gh api repos/Comfy-Org/comfy-cli/releases -q length
30

Fix

Settings → Branches → rule for main: require a PR with at least one approval, require pytest, ruff_check, and build-and-test as status checks, block force pushes. Leave the GPU and mac/windows matrices advisory if they are flaky, but make the core three required.


Found by repo-audit during repo improvement sweep 2026-08-17. Parent: #723

主要语言
Python
星标
1k
派生
176
平均合并
1 天 11 小时
30 天内合并 PR
87

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

Comfy-Org/comfy-cli 的其他 Issue

查看 Comfy-Org/comfy-cli 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。