Enable branch protection — 13 workflows, none of them required

Abierto
#724 0 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@christian-byrne ya está trabajando en esto.

Desde el 23/8/2026.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

audit:github effort:trivial priority:critical

What — main has no branch protection rule, so none of the repo's 13 workflows is a required status check.

Why it matters here — This is a public package with 45 contributors and 30 published releases. pytest, ruff, build-and-test, and the mac/windows/GPU matrices all run on every PR and every one of them is advisory — a PR with a red test suite can be merged and published. The checks are already written and already run; they just do not block. Of the six repos swept this is the one where the gap costs the most, because releases go to PyPI.

Evidence

$ gh api repos/Comfy-Org/comfy-cli/branches/main/protection
gh: Branch not protected (HTTP 404)

$ ls .github/workflows/ | wc -l
13

$ gh api repos/Comfy-Org/comfy-cli -q '"contributors_visible releases=\(.  )"' ; gh api repos/Comfy-Org/comfy-cli/releases -q length
30

Fix

Settings → Branches → rule for main: require a PR with at least one approval, require pytest, ruff_check, and build-and-test as status checks, block force pushes. Leave the GPU and mac/windows matrices advisory if they are flaky, but make the core three required.


Found by repo-audit during repo improvement sweep 2026-08-17. Parent: #723

Lenguaje dominante
Python
Estrellas
1k
Forks
176
Merge medio
1 d 11 h
PR fusionados (30 d)
87

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Comfy-Org/comfy-cli

Todos los issues de Comfy-Org/comfy-cli

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.