Enable branch protection — 13 workflows, none of them required

Aperta
#724 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@christian-byrne ci sta già lavorando.

Dal 23/8/2026.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

audit:github effort:trivial priority:critical

What — main has no branch protection rule, so none of the repo's 13 workflows is a required status check.

Why it matters here — This is a public package with 45 contributors and 30 published releases. pytest, ruff, build-and-test, and the mac/windows/GPU matrices all run on every PR and every one of them is advisory — a PR with a red test suite can be merged and published. The checks are already written and already run; they just do not block. Of the six repos swept this is the one where the gap costs the most, because releases go to PyPI.

Evidence

$ gh api repos/Comfy-Org/comfy-cli/branches/main/protection
gh: Branch not protected (HTTP 404)

$ ls .github/workflows/ | wc -l
13

$ gh api repos/Comfy-Org/comfy-cli -q '"contributors_visible releases=\(.  )"' ; gh api repos/Comfy-Org/comfy-cli/releases -q length
30

Fix

Settings → Branches → rule for main: require a PR with at least one approval, require pytest, ruff_check, and build-and-test as status checks, block force pushes. Leave the GPU and mac/windows matrices advisory if they are flaky, but make the core three required.


Found by repo-audit during repo improvement sweep 2026-08-17. Parent: #723

Lingua principale
Python
Stelle
1k
Fork
176
Merge medio
1g 11h
PR unite (30g)
87

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Comfy-Org/comfy-cli

Tutte le issue di Comfy-Org/comfy-cli

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.