Upgrade a benefit's eligibility check to a newer published version
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 48/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- typescript
- 领域
- frontend
调研方向
Start in SelectedEligibilityCheck.tsx and trace EligibilityCheckRepository.getPublishedCheckVersions and getWorkingId. Verify how a pinned CheckConfig is upgraded while preserving parameters and alias, and how incompatible changes prompt review. Done means newer versions are surfaced and upgradeable without changing already-published screeners.
由索引模型根据 Issue 内容生成。
描述
Problem
A benefit pins each custom check to one published version (CheckConfig.checkId + checkVersion). When the check's author publishes a newer version, benefits that use the check keep running the old one. That's intended, because published versions are frozen. But nothing in the UI says a newer version exists, and the only way to upgrade is to remove the check from the benefit and add it back, which loses its parameters and alias.
This matters more now that checks can be renamed (#512). A check called "A" at 1.0.0 might be called "B" at 1.1.0, and users would have to recognize it as the same check to upgrade.
Proposal
- In the benefit editor (
SelectedEligibilityCheck.tsx), show when a newer published version of a pinned custom check exists, e.g. "A 1.0.0 → B 1.1.0 available". - Add an upgrade action that repoints the
CheckConfigat the newer published version while keeping its parameters and alias. - Handle changes between versions: parameters that were added (especially required ones), removed, or changed type, and a changed input definition. Ask the user to review the configuration before saving instead of failing silently.
- Leave already-published screeners alone. They should keep running the version they were published with until the screener is republished.
Notes
Published versions of a check are linked by the check's working ID. P-<suffix>-<version> corresponds to W-<suffix>, and EligibilityCheckRepository.getPublishedCheckVersions / getWorkingId already map between them. As of #512, check IDs no longer depend on the check's name, so all published versions of a check can be found by that ID even after a rename.
Open questions:
- Should an upgrade that isn't backward compatible (e.g. a new required parameter) be allowed, or blocked until the user fills in the new parameter?
- Should the same prompt show for library checks, which have their own versioning?
- 主要语言
- Java
- 星标
- 16
- 派生
- 5
- 平均合并
- 17 小时 24 分钟
- 30 天内合并 PR
- 23
环境准备
我们还没有检查这个项目的环境配置文件。先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
CodeForPhilly/benefit-decision-toolkit 的其他 Issue
-
documentation Good for newcomer quick win
难度 2/5 1-3 小时 新手友好度 68/100
CodeForPhilly/benefit-decision-toolkit#519 ·
维护者通常 1 天内回复
-
documentation quick win
难度 2/5 1-3 小时 新手友好度 68/100
CodeForPhilly/benefit-decision-toolkit#445 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
CodeForPhilly/benefit-decision-toolkit#425 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 48/100
CodeForPhilly/benefit-decision-toolkit#525 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 45/100
CodeForPhilly/benefit-decision-toolkit#524 ·
维护者通常 1 天内回复
查看 CodeForPhilly/benefit-decision-toolkit 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
redhat-developer/intellij-quarkus#1626 ·
-
Type/Bug
难度 2/5 1-3 小时 新手友好度 68/100
wso2/product-integrator-mi#5061 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
quarkiverse/quarkus-roq#1277 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 90/100
apache/logging-site#48 ·
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
apache/maven-surefire#3496 · 3 条评论 ·
维护者通常 1 天内回复