Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Upgrade a benefit's eligibility check to a newer published version

Aperta
  • Qualcosa non va?
#516 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
frontend

Direzione di ricerca

Start in SelectedEligibilityCheck.tsx and trace EligibilityCheckRepository.getPublishedCheckVersions and getWorkingId. Verify how a pinned CheckConfig is upgraded while preserving parameters and alias, and how incompatible changes prompt review. Done means newer versions are surfaced and upgradeable without changing already-published screeners.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

backend frontend

Problem

A benefit pins each custom check to one published version (CheckConfig.checkId + checkVersion). When the check's author publishes a newer version, benefits that use the check keep running the old one. That's intended, because published versions are frozen. But nothing in the UI says a newer version exists, and the only way to upgrade is to remove the check from the benefit and add it back, which loses its parameters and alias.

This matters more now that checks can be renamed (#512). A check called "A" at 1.0.0 might be called "B" at 1.1.0, and users would have to recognize it as the same check to upgrade.

Proposal

  • In the benefit editor (SelectedEligibilityCheck.tsx), show when a newer published version of a pinned custom check exists, e.g. "A 1.0.0 → B 1.1.0 available".
  • Add an upgrade action that repoints the CheckConfig at the newer published version while keeping its parameters and alias.
  • Handle changes between versions: parameters that were added (especially required ones), removed, or changed type, and a changed input definition. Ask the user to review the configuration before saving instead of failing silently.
  • Leave already-published screeners alone. They should keep running the version they were published with until the screener is republished.

Notes

Published versions of a check are linked by the check's working ID. P-<suffix>-<version> corresponds to W-<suffix>, and EligibilityCheckRepository.getPublishedCheckVersions / getWorkingId already map between them. As of #512, check IDs no longer depend on the check's name, so all published versions of a check can be found by that ID even after a rename.

Open questions:

  • Should an upgrade that isn't backward compatible (e.g. a new required parameter) be allowed, or blocked until the user fills in the new parameter?
  • Should the same prompt show for library checks, which have their own versioning?
Lingua principale
Java
Stelle
16
Fork
5
Merge medio
15h 42m
PR unite (30g)
21

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

  • Nessun Dockerfile né file Docker Compose
  • Ha un modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di CodeForPhilly/benefit-decision-toolkit

Tutte le issue di CodeForPhilly/benefit-decision-toolkit

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.