Upgrade a benefit's eligibility check to a newer published version
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 48/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- typescript
- Área
- frontend
Línea de trabajo
Start in SelectedEligibilityCheck.tsx and trace EligibilityCheckRepository.getPublishedCheckVersions and getWorkingId. Verify how a pinned CheckConfig is upgraded while preserving parameters and alias, and how incompatible changes prompt review. Done means newer versions are surfaced and upgradeable without changing already-published screeners.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Problem
A benefit pins each custom check to one published version (CheckConfig.checkId + checkVersion). When the check's author publishes a newer version, benefits that use the check keep running the old one. That's intended, because published versions are frozen. But nothing in the UI says a newer version exists, and the only way to upgrade is to remove the check from the benefit and add it back, which loses its parameters and alias.
This matters more now that checks can be renamed (#512). A check called "A" at 1.0.0 might be called "B" at 1.1.0, and users would have to recognize it as the same check to upgrade.
Proposal
- In the benefit editor (
SelectedEligibilityCheck.tsx), show when a newer published version of a pinned custom check exists, e.g. "A 1.0.0 → B 1.1.0 available". - Add an upgrade action that repoints the
CheckConfigat the newer published version while keeping its parameters and alias. - Handle changes between versions: parameters that were added (especially required ones), removed, or changed type, and a changed input definition. Ask the user to review the configuration before saving instead of failing silently.
- Leave already-published screeners alone. They should keep running the version they were published with until the screener is republished.
Notes
Published versions of a check are linked by the check's working ID. P-<suffix>-<version> corresponds to W-<suffix>, and EligibilityCheckRepository.getPublishedCheckVersions / getWorkingId already map between them. As of #512, check IDs no longer depend on the check's name, so all published versions of a check can be found by that ID even after a rename.
Open questions:
- Should an upgrade that isn't backward compatible (e.g. a new required parameter) be allowed, or blocked until the user fills in the new parameter?
- Should the same prompt show for library checks, which have their own versioning?
- Lenguaje dominante
- Java
- Estrellas
- 16
- Forks
- 5
- Merge medio
- 14 h 45 min
- PR fusionados (30 d)
- 25
Preparar el entorno
Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Sin guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de CodeForPhilly/benefit-decision-toolkit
-
Make docs website more visibleAbiertodocumentation Good for newcomer quick win
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
CodeForPhilly/benefit-decision-toolkit#519 ·
Los mantenedores suelen responder en 1 día
-
documentation quick win
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
CodeForPhilly/benefit-decision-toolkit#445 ·
Los mantenedores suelen responder en 1 día
-
Make issue templatesAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
CodeForPhilly/benefit-decision-toolkit#425 ·
Los mantenedores suelen responder en 1 día
-
Update docs screenshots to reflect new navigation design and use the actual in-app example screenerAbierto
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
CodeForPhilly/benefit-decision-toolkit#528 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 45/100
CodeForPhilly/benefit-decision-toolkit#524 ·
Los mantenedores suelen responder en 1 día
Todos los issues de CodeForPhilly/benefit-decision-toolkit
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
beehive-lab/TornadoVM#1151 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
Los mantenedores suelen responder en 1 día
-
(cbor) `maxStringLength` not consistently checked for chunked (indefinite-length) text valuesAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
FasterXML/jackson-dataformats-binary#823 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día