Missing ngtsc diagnostics for invalid inputs, outputs, queries and signal APIs
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 52/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- angular, rust, typescript
- 領域
- compilers
研究方向
Start in crates/oxc_angular_compiler/src/directive/property_decorators.rs and directive/decorator.rs, then compare the corresponding ngtsc checks in shared.ts and input_output_parse_options.ts. Review initializer_api_usage_rule.ts for NG8110. Use the checklist snippets as repro cases; done means the expected diagnostics are emitted and the incorrect bindings, queries, and metadata are no longer produced.
由索引模型根據 Issue 內容生成。
描述
ngtsc 22.1.7 rejects each form below. OXC (main and #504 tip, 3e0b07f) compiles them with no diagnostic. Often the output is wrong too: a binding is dropped, duplicated, or a query is registered twice.
Each snippet uses import {Component, Directive, Input, Output, EventEmitter, ViewChild, ContentChild, input, output, viewChild, model} from '@angular/core';.
Checklist
ngtsc message is exact (codes shown as NGxxxx). The OXC column is #504 tip; main is the same.
- Decorator on a signal query.
@ViewChild('a') q = viewChild('a');
ngtsc:NG1050: Using @ViewChild with a signal-based query is not allowed.(same for@ContentChildetc.)
OXC: no error. Emits a decoratorɵɵviewQuery. -
input()/model()not used directly as a field initializer.a = input(0)!;,m = model(0)!;,a = input(0) satisfies any;,constructor() { const x = input(0); }
ngtsc:NG8110: Unsupported call to the input function. This function can only be called in the initializer of a class member.(modelgives "...the model function...")
OXC: no error. The input is silently left out ofinputs. - Signal API on a
private/#privatemember.private a = input(0);/#a = input(0);
ngtsc:NG1053: Cannot use "input" on a class member that is declared as private. Update the class field to be either: public, public readonly, protected(... declared as ES private. ...for#a)
OXC: no error.privatecompiles as a normal input.#ais silently dropped. - Signal option alias is not a string literal.
a = input(0, {alias: 1 as any});,o = output({alias: 1 as any});, andinput(0, {alias: ALIAS})withALIASimported from another file
ngtsc:NG1010: Alias needs to be a string that is statically analyzable.
OXC: no error. The alias is ignored (inputs:{a:[1,"a"]},outputs:{o:"o"}). - Two members bound to the same public name.
@Input('y') x: any; @Input() y: any;
ngtsc:NG1054: Input 'y' is bound to both 'x' and 'y'.
Same for outputs:NG1054: Output 'y' is bound to both 'x' and 'y'.
OXC: no error. Both are emitted (outputs:{x:"y",y:"y"}). - Two query decorators on one member.
@ViewChild('a') @ContentChild('b') q: any;
ngtsc:NG1006: Cannot combine multiple query decorators.
OXC: no error. Emits both acontentQueryand aviewQuerywriting toctx.q. -
@Inputtogether with a query decorator.@Input() @ViewChild('a') q: any;
ngtsc:NG1006: Cannot combine @Input decorators with query decorators
OXC: no error. Emits bothinputs:{q:"q"}and aviewQuery. - Static members.
@Input() static a: any;→NG1100: Input "a" is incorrectly declared as static member of "D".@ViewChild('a') static q: any;→NG1100: Query is incorrectly declared on a static class member.@Output() static o = new EventEmitter();→NG1100: Output is incorrectly declared on a static class member.
OXC: no error. All three are emitted as if they were instance members.
-
@Output()on a setter.@Output() set o(v: any) {}
ngtsc compiles it:outputs: { o: "o" }. With a bad argument,@Output(1 as any) set o(v: any) {}, it reportsNG1010: @Output decorator argument must resolve to a string Value is of type 'number'.
OXC: drops the output (nooutputs,{}in.d.ts) and does not check the argument. - Directive with
selector: ''.@Directive({selector: ''}) export class D {}
ngtsc:NG2004: Directive D has no selector, please add it!
OXC: no error. EmitsɵɵdefineDirective({type:D})and""as the.d.tsselector. (Components withselector: ''are tracked separately.)
Where ngtsc raises them (Angular v22.0.0 source)
packages/compiler-cli/src/ngtsc/annotations/directive/src/shared.ts: NG2004, NG1006 ×2, NG1054 ×2, NG1100 ×3, NG1050.../annotations/directive/src/initializer_function_access.ts: NG1053.../annotations/directive/src/input_output_parse_options.ts: alias NG1010.../validation/src/rules/initializer_api_usage_rule.ts: NG8110 (a source-file check, not part of the decorator handler)
On the OXC side, most belong in crates/oxc_angular_compiler/src/directive/property_decorators.rs and directive/decorator.rs.
On main?
Yes, all of them. The stack doesn't change these cases.
- 主要語言
- Rust
- 星號
- 235
- 分支
- 21
- 平均合併
- 1 天 15 小時
- 30 天內合併 PR
- 65
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
voidzero-dev/oxc-angular-compiler 的其他 Issue
-
bug
難度 4/5 3-5 天 新手友好度 68/100
voidzero-dev/oxc-angular-compiler#505 ·
維護者通常 1 天內回覆
-
bug rust
難度 4/5 3-5 天 新手友好度 56/100
voidzero-dev/oxc-angular-compiler#313 ·
維護者通常 1 天內回覆
-
Support useDefineForClassFields: false (Class Field Lowering)可能已有人在做 關聯的 PR 仍在進行中或已合併。 未關閉
難度 5/5 一週以上 新手友好度 35/100
voidzero-dev/oxc-angular-compiler#73 · 11 則留言 ·
維護者通常 1 天內回覆
-
Angular 21.2.0 + @oxc-angular/vite 0.0.7 SSR runtime parity regressions (RouterLinkActive, Forms DI, Apollo DI) require app-level shims可能重新可做 @Brooooooklyn 於 226 天前認領,目前沒有進行中的 PR。 未關閉
voidzero-dev/oxc-angular-compiler#61 · 已指派 1 人 ·
維護者通常 1 天內回覆
-
Angular 21.2.0 + @oxc-angular/vite 0.0.7 SSR: AngularNodeAppEngine is unusable (missing app-engine manifest)可能重新可做 @Brooooooklyn 於 226 天前認領,目前沒有進行中的 PR。 未關閉
voidzero-dev/oxc-angular-compiler#60 · 4 則留言 · 已指派 1 人 ·
維護者通常 1 天內回覆
查看 voidzero-dev/oxc-angular-compiler 的全部 Issue
相似的 Issue
-
build: Update rust version可能已有人在做 關聯的 PR 仍在進行中或已合併。 未關閉dependencies
難度 2/5 1-3 小時 新手友好度 67/100
ibm-granite-community/granite-cli#229 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
orottier/web-audio-api-rs#658 ·
-
難度 2/5 1-3 小時 新手友好度 84/100
aosama/astronomical#1318 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 66/100
shep-pm/shep-kelpie#980 ·
維護者通常 1 天內回覆