Missing ngtsc diagnostics for invalid inputs, outputs, queries and signal APIs
Les mainteneurs répondent en général sous 1 jour
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 52/100
- Type d'issue
- Bug
- Clarté
- Clairement spécifiée
- Activité
- Active
- Stack technique
- angular, rust, typescript
- Domaine
- compilers
Piste de recherche
Start in crates/oxc_angular_compiler/src/directive/property_decorators.rs and directive/decorator.rs, then compare the corresponding ngtsc checks in shared.ts and input_output_parse_options.ts. Review initializer_api_usage_rule.ts for NG8110. Use the checklist snippets as repro cases; done means the expected diagnostics are emitted and the incorrect bindings, queries, and metadata are no longer produced.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
ngtsc 22.1.7 rejects each form below. OXC (main and #504 tip, 3e0b07f) compiles them with no diagnostic. Often the output is wrong too: a binding is dropped, duplicated, or a query is registered twice.
Each snippet uses import {Component, Directive, Input, Output, EventEmitter, ViewChild, ContentChild, input, output, viewChild, model} from '@angular/core';.
Checklist
ngtsc message is exact (codes shown as NGxxxx). The OXC column is #504 tip; main is the same.
- Decorator on a signal query.
@ViewChild('a') q = viewChild('a');
ngtsc:NG1050: Using @ViewChild with a signal-based query is not allowed.(same for@ContentChildetc.)
OXC: no error. Emits a decoratorɵɵviewQuery. -
input()/model()not used directly as a field initializer.a = input(0)!;,m = model(0)!;,a = input(0) satisfies any;,constructor() { const x = input(0); }
ngtsc:NG8110: Unsupported call to the input function. This function can only be called in the initializer of a class member.(modelgives "...the model function...")
OXC: no error. The input is silently left out ofinputs. - Signal API on a
private/#privatemember.private a = input(0);/#a = input(0);
ngtsc:NG1053: Cannot use "input" on a class member that is declared as private. Update the class field to be either: public, public readonly, protected(... declared as ES private. ...for#a)
OXC: no error.privatecompiles as a normal input.#ais silently dropped. - Signal option alias is not a string literal.
a = input(0, {alias: 1 as any});,o = output({alias: 1 as any});, andinput(0, {alias: ALIAS})withALIASimported from another file
ngtsc:NG1010: Alias needs to be a string that is statically analyzable.
OXC: no error. The alias is ignored (inputs:{a:[1,"a"]},outputs:{o:"o"}). - Two members bound to the same public name.
@Input('y') x: any; @Input() y: any;
ngtsc:NG1054: Input 'y' is bound to both 'x' and 'y'.
Same for outputs:NG1054: Output 'y' is bound to both 'x' and 'y'.
OXC: no error. Both are emitted (outputs:{x:"y",y:"y"}). - Two query decorators on one member.
@ViewChild('a') @ContentChild('b') q: any;
ngtsc:NG1006: Cannot combine multiple query decorators.
OXC: no error. Emits both acontentQueryand aviewQuerywriting toctx.q. -
@Inputtogether with a query decorator.@Input() @ViewChild('a') q: any;
ngtsc:NG1006: Cannot combine @Input decorators with query decorators
OXC: no error. Emits bothinputs:{q:"q"}and aviewQuery. - Static members.
@Input() static a: any;→NG1100: Input "a" is incorrectly declared as static member of "D".@ViewChild('a') static q: any;→NG1100: Query is incorrectly declared on a static class member.@Output() static o = new EventEmitter();→NG1100: Output is incorrectly declared on a static class member.
OXC: no error. All three are emitted as if they were instance members.
-
@Output()on a setter.@Output() set o(v: any) {}
ngtsc compiles it:outputs: { o: "o" }. With a bad argument,@Output(1 as any) set o(v: any) {}, it reportsNG1010: @Output decorator argument must resolve to a string Value is of type 'number'.
OXC: drops the output (nooutputs,{}in.d.ts) and does not check the argument. - Directive with
selector: ''.@Directive({selector: ''}) export class D {}
ngtsc:NG2004: Directive D has no selector, please add it!
OXC: no error. EmitsɵɵdefineDirective({type:D})and""as the.d.tsselector. (Components withselector: ''are tracked separately.)
Where ngtsc raises them (Angular v22.0.0 source)
packages/compiler-cli/src/ngtsc/annotations/directive/src/shared.ts: NG2004, NG1006 ×2, NG1054 ×2, NG1100 ×3, NG1050.../annotations/directive/src/initializer_function_access.ts: NG1053.../annotations/directive/src/input_output_parse_options.ts: alias NG1010.../validation/src/rules/initializer_api_usage_rule.ts: NG8110 (a source-file check, not part of the decorator handler)
On the OXC side, most belong in crates/oxc_angular_compiler/src/directive/property_decorators.rs and directive/decorator.rs.
On main?
Yes, all of them. The stack doesn't change these cases.
- Langage dominant
- Rust
- Étoiles
- 232
- Forks
- 21
- Merge moyen
- 1 j 18 h
- PR mergées (30 j)
- 59
Préparer son environnement
Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de voidzero-dev/oxc-angular-compiler
-
Difficulté 4/5 3-5 jours Accessibilité débutants 55/100
voidzero-dev/oxc-angular-compiler#563 ·
Les mainteneurs répondent en général sous 1 jour
-
e2e compare: setClassMetadata extraction regex never matches (ɵɵ vs ɵ) — classMetadataDiffs is dead codePeut-être pris @Brooooooklyn l’a pris aujourd’hui. Ouverte
Difficulté 4/5 3-5 jours Accessibilité débutants 38/100
voidzero-dev/oxc-angular-compiler#561 ·
Les mainteneurs répondent en général sous 1 jour
-
bug
Difficulté 4/5 3-5 jours Accessibilité débutants 68/100
voidzero-dev/oxc-angular-compiler#506 ·
Les mainteneurs répondent en général sous 1 jour
-
fix(directive): input names with lone surrogates are emitted in oxc's internal U+FFFD encodingOuvertebug
Difficulté 4/5 3-5 jours Accessibilité débutants 68/100
voidzero-dev/oxc-angular-compiler#505 ·
Les mainteneurs répondent en général sous 1 jour
-
bug rust
Difficulté 4/5 3-5 jours Accessibilité débutants 56/100
voidzero-dev/oxc-angular-compiler#313 ·
Les mainteneurs répondent en général sous 1 jour
Toutes les issues de voidzero-dev/oxc-angular-compiler
Issues similaires
-
Difficulté 2/5 1-3 heures Accessibilité débutants 76/100
Les mainteneurs répondent en général sous 1 jour
-
app enhancement
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 85/100
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 1/5 Moins d'une heure Accessibilité débutants 80/100
elodin-sys/elodin#890 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 85/100
guidance-ai/llguidance#391 ·